[Merged by Bors] - Include 2x/8x sample counts for Msaa #7684
Conversation
Aceeri
added
C-Enhancement
james7132
added
the
S-Ready-For-Final-Review
There was a problem hiding this comment.
This should default to the default value (so 4) if it's supported and not what is asked, then disable if even the default value is not supported
So
- 2x / 8x requested but not supported, 4x is supported -> set it to 4x
- 2x / 4x / 8x not supported -> set it to off
This should be the case now |
| msaa.samples(), | ||
| ); | ||
| *msaa = Msaa::Off; | ||
| if sample_flags.sample_count_supported(Msaa::default().samples()) { |
There was a problem hiding this comment.
Rather than two different log statements in and f, use the if statement to determine the fallback sample count, and then set that once and use one log statement. That will be cleaner.
Pseudo code:
let fallback_sample = if default_supported() { default } else { off };
log("Not supported, falling back to {fallback_sample}");
*msaa = fallback_sample;
| Msaa::Off | ||
| }; | ||
|
|
||
| let fallback_str = if fallback == Msaa::Off { |
There was a problem hiding this comment.
Actually small nit. Remove to_owned(), and &borrow the format!().
There was a problem hiding this comment.
I don't think that will work since it doesn't live long enough
| let fallback_str = if fallback == Msaa::Off { | ||
| "disabling MSAA".to_owned() | ||
| } else { | ||
| format!("MSAA {}x", fallback.samples()) | ||
| }; |
There was a problem hiding this comment.
It would be nicer to use a Debug (or Display) impl of the Masa enum
# Objective Fixes #7295 Should we maybe default to 4x if 2x/8x is selected but not supported? --- ## Changelog - Added 2x and 8x sample counts for MSAA.
bors
bot
changed the title
# Objective Fixes bevyengine#7295 Should we maybe default to 4x if 2x/8x is selected but not supported? --- ## Changelog - Added 2x and 8x sample counts for MSAA.
Objective
Fixes #7295
Should we maybe default to 4x if 2x/8x is selected but not supported?
Changelog