[Merged by Bors] - Update sysinfo and improve its use a bit #7826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
commented
Feb 26, 2023
| @@ -69,23 +69,19 @@ pub mod internal { | |||
| mut sysinfo: Local<Option<System>>, | |||
| ) { | |||
| if sysinfo.is_none() { | |||
| *sysinfo = Some(System::new_all()); | |||
| *sysinfo = Some(System::new_with_specifics( | |||
There was a problem hiding this comment.
System::new_all will retrieve a lot more information than what is being used here like all processes, network interfaces, etc... Since you only care about system memory and CPU usage, no need for everything else. Especially since you'll keep this one around! It should drop the memory impact by quite a lot.
GuillaumeGomez
commented
Feb 26, 2023
| // average | ||
| usage / cpus.len() as f32 | ||
| }; | ||
| let current_cpu_usage = sys.global_cpu_info().cpu_usage(); |
There was a problem hiding this comment.
No need to go through all CPU to get the average information, it is already available in the global_cpu_info.
mockersf
approved these changes
Feb 26, 2023
mockersf
added
C-Dependencies
IceSentry
approved these changes
Feb 26, 2023
bors bot
pushed a commit
that referenced
this pull request
Feb 27, 2023
I made a few internal fixes in sysinfo so why not be able to benefit from them? :) I explain the other changes directly in diff comments.
|
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
Shfty
pushed a commit
to shfty-rust/bevy
that referenced
this pull request
Mar 19, 2023
I made a few internal fixes in sysinfo so why not be able to benefit from them? :) I explain the other changes directly in diff comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a few internal fixes in sysinfo so why not be able to benefit from them? :)
I explain the other changes directly in diff comments.