Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Add unsupported platforms note to ui window fallthrough example #7827

Closed
wants to merge 1 commit into from

Conversation

iwek7
Copy link
Contributor

@iwek7 iwek7 commented Feb 26, 2023

Objective

This adds small comment to window fall through example that it won't work on specific platforms. This information is documented in Cursor api but I think it is worth to add it in example description for clarity sake.

@mockersf mockersf added C-Docs An addition or correction to our documentation C-Examples An addition or correction to our examples labels Feb 26, 2023
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 26, 2023
Copy link
Member

@james7132 james7132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot pushed a commit that referenced this pull request Feb 27, 2023
# Objective
This adds small comment to window fall through example that it won't work on specific platforms. This information is documented in `Cursor` api but I think it is worth to add it in example description for clarity sake.
@bors bors bot changed the title Add unsupported platforms note to ui window fallthrough example [Merged by Bors] - Add unsupported platforms note to ui window fallthrough example Feb 27, 2023
@bors bors bot closed this Feb 27, 2023
Shfty pushed a commit to shfty-rust/bevy that referenced this pull request Mar 19, 2023
…engine#7827)

# Objective
This adds small comment to window fall through example that it won't work on specific platforms. This information is documented in `Cursor` api but I think it is worth to add it in example description for clarity sake.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Docs An addition or correction to our documentation C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants