Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Use default-implemented methods for IntoSystemConfig<> #7870

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - Use default-implemented methods for IntoSystemConfig<> #7870

wants to merge 5 commits into from

Conversation

JoJoJet
Copy link
Member

@JoJoJet JoJoJet commented Mar 2, 2023

Objective

The trait IntoSystemConfig<> requires each implementer to repeat every single member method, even though they can all be implemented by just deferring to SystemConfig.

Solution

Add default implementations to most member methods.

@JoJoJet JoJoJet added A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change labels Mar 2, 2023
@alice-i-cecile
Copy link
Member

Ping @geieredgar for review too if you have time :)

geieredgar
geieredgar approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@geieredgar geieredgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hymm hymm added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 2, 2023
james7132
james7132 approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@james7132 james7132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less code is better code.

bors r+

bors bot pushed a commit that referenced this pull request Mar 2, 2023
@JoJoJet
Use default-implemented methods for IntoSystemConfig<> (#7870)
7cd2ee2 
# Objective

The trait `IntoSystemConfig<>` requires each implementer to repeat every single member method, even though they can all be implemented by just deferring to `SystemConfig`.

## Solution

Add default implementations to most member methods.
@bors
Copy link
Contributor

bors bot commented Mar 2, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Use default-implemented methods for IntoSystemConfig<> [Merged by Bors] - Use default-implemented methods for IntoSystemConfig<> Mar 2, 2023
@bors bors bot closed this Mar 2, 2023
@JoJoJet JoJoJet deleted the default-system-config-impls branch March 2, 2023 17:38
Shfty pushed a commit to shfty-rust/bevy that referenced this pull request Mar 19, 2023
@JoJoJet @Shfty
Use default-implemented methods for IntoSystemConfig<> (bevyengine#…
4968b6b 
…7870)

# Objective

The trait `IntoSystemConfig<>` requires each implementer to repeat every single member method, even though they can all be implemented by just deferring to `SystemConfig`.

## Solution

Add default implementations to most member methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maniwani maniwani maniwani approved these changes

@geieredgar geieredgar geieredgar approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@james7132 james7132 james7132 approved these changes

@hymm hymm Awaiting requested review from hymm

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JoJoJet @alice-i-cecile @james7132 @geieredgar @maniwani @hymm