Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove bors and small CI improvements #7947

Merged
merged 11 commits into from
Mar 7, 2023

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Mar 7, 2023

Objective

  • Remove bors
  • Some CI improvements

Solution

  • Moving from bors to merge queues:
    • Remove bors config and support for bors branches
    • Add a unique status job for the matrix in validation that can be used in branch protection rules
  • Reduce load:
    • Remove cron execution on dependency check jobs. did anyone check those?
    • Move the unused dependency check from CI to validation so that it runs less often. it doesn't raise issues enough to keep it on every push
  • Use less runners at the start without changing the total duration. This reduce the "burst" usage so that more PRs can run in parallel
    • Reorder markdown jobs (examples, features, lint) so that they run sequentially
    • Reduce parallelism of "no default features" job matrix

@mockersf mockersf added the A-Build-System Related to build systems or continuous integration label Mar 7, 2023
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contributing.md mentions bors and needs to be updated too.

@james7132
Copy link
Member

I think this should be marked as fixing #7824. Seems like we've made the move completely with this.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 7, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 7, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 7, 2023
@alice-i-cecile
Copy link
Member

alice-i-cecile commented Mar 7, 2023

Run rustup toolchain install --profile minimal --no-self-update
error: error: The following required arguments were not provided:
...

USAGE:
rustup toolchain install ... --no-self-update --profile

check-unused-dependencies is failing.

@mockersf
Copy link
Member Author

mockersf commented Mar 7, 2023

oh, a missing environment variable... fixed!

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 7, 2023
Merged via the queue into bevyengine:main with commit cd06fad Mar 7, 2023
Shfty pushed a commit to shfty-rust/bevy that referenced this pull request Mar 19, 2023
Shfty pushed a commit to shfty-rust/bevy that referenced this pull request Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Build-System Related to build systems or continuous integration S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants