Fix the Text2d text anchor's incorrect horizontal alignment
#8019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into fix-text2d-anchor
ickshonpe
changed the title
Text2d text anchor's incorrect horizontal alignment
TimJentzsch
approved these changes
Mar 10, 2023
james7132
added
C-Bug
james7132
approved these changes
Mar 10, 2023
james7132
added
the
S-Ready-For-Final-Review
rparrett
approved these changes
Mar 10, 2023
|
The changelog and objective / solution don't match: are we dealing with the x or y axis here? |
alice-i-cecile
approved these changes
Mar 10, 2023
Sorry, X-axis is correct. |
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Mar 10, 2023
Shfty
pushed a commit
to shfty-rust/bevy
that referenced
this pull request
Mar 19, 2023
Shfty
pushed a commit
to shfty-rust/bevy
that referenced
this pull request
Mar 19, 2023
mockersf
pushed a commit
that referenced
this pull request
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
The Text2dBundle::text_anchor is incorrectly inverted on the X-axis.
Fixes: #8011
Solution
Reverse the x-axis on the text anchor translation.
Changelog
Text2dtext anchor point being wrongly inverted on the X axis.text_anchorto theText2dexample.Migration Guide
Text2d::text_anchorwas incorrectly inverted on the X-axis. This has been fixed, existing code needs to swap:Anchor::BottomLeftandAnchor::BottomRightAnchor::CenterLeftandAnchor::CenterRightAnchor::TopLeftandAnchor::TopRight