-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
daily job running mobile example on real devices #8216
Conversation
@@ -229,6 +229,7 @@ | |||
CLANG_WARN_UNGUARDED_AVAILABILITY = YES_AGGRESSIVE; | |||
CLANG_WARN_UNREACHABLE_CODE = YES; | |||
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES; | |||
CODE_SIGN_IDENTITY = ""; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CODE_SIGN_IDENTITY = ""
is needed to be able to build the app without signing it in CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you leave a comment in this type of file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file is not meant to be read, it's generated and managed through xcode. It's also a setting specific to Bevy as an engine, someone creating a game and targeting iOS will have a signing identity. As Bevy is not paying the 100$/year apple development subscription, we don't have one.
PRODUCT_BUNDLE_IDENTIFIER = "com.rust.bevy_mobile_example"; | ||
PRODUCT_BUNDLE_IDENTIFIER = "org.bevyengine.example"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is so that both Android and iOS have the same package name
5253a62
to
cdfc498
Compare
Controversial label added because of the third party integration. Strongly in favor of this though: there's a been quite a few surprising regressions, and if we're going to get mobile support working in earnest we need to be testing on real devices. |
(@mockersf sent me the secrets. I added them to the Bevy Org and gave the bevy repo access) |
Objective
Solution
Example run: https://github.com/mockersf/bevy/actions/runs/4521883534
They currently have a bug with the settings to view snapshots, they should be public. I'll raise it to them, and if they don't fix it in time it's possible to work around for everyone to view the results through their API.
@cart to get this to work, you'll need
BROWSERSTACK_USERNAME
andBROWSERSTACK_ACCESS_KEY
to the Bevy repoPERCY_TOKEN
to the Bevy repo and modify the project name line 122 in theDaily.yml
file