bevy_render: delegate buffer aligning to RenderResourceContext #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrk-its
commented
Nov 11, 2020
| @@ -482,23 +479,6 @@ fn render_resources_node_system<T: RenderResources>( | |||
| state | |||
| .uniform_buffer_arrays | |||
| .copy_staging_buffer_to_final_buffers(&mut state.command_queue, staging_buffer); | |||
| } else { | |||
| // TODO: can we just remove this? | |||
There was a problem hiding this comment.
It seems it can be safely removed, tested a lot of bevy examples without it and everything seems to work.
|
Looks good to me! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebGL2has different uniform / texture aligning requirements thanwgpu. This PR moves uniform / texture aligning code to RenderResourceContext. Current aligning behaviour forwgpushould be preserved.