Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic in example: text_wrap_debug.rs #8497

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Fix panic in example: text_wrap_debug.rs #8497

merged 1 commit into from
Apr 26, 2023

Conversation

ameknite
Copy link
Contributor

@ameknite ameknite commented Apr 26, 2023 •
edited
Loading

Objective

  • Fix panic caused by incorrectly placed background color

Solution

  • Move BackgroundColor inside TextBundle

@ameknite ameknite changed the title fix panic Fix panic in example: text_wrap_debug.rs Apr 26, 2023
@nicopap nicopap self-requested a review April 26, 2023 07:31
@ickshonpe
Copy link
Contributor

😓 wrote this example before the change that added background_color to TextBundle

@nicopap nicopap added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples A-UI Graphical user interfaces, styles, layouts, and widgets P-Crash A sudden unexpected crash and removed C-Bug An unexpected or incorrect behavior labels Apr 26, 2023
@mockersf mockersf added this pull request to the merge queue Apr 26, 2023
Merged via the queue into bevyengine:main with commit 670f3f0 Apr 26, 2023
@ameknite ameknite deleted the fix_panic_text_wrap_debug branch April 27, 2023 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@nicopap nicopap nicopap approved these changes

@ickshonpe ickshonpe ickshonpe approved these changes

Assignees
No one assigned
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Examples An addition or correction to our examples P-Crash A sudden unexpected crash S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ameknite @ickshonpe @mockersf @nicopap