Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add window entity to mouse and keyboard events #8852

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Add window entity to mouse and keyboard events #8852

merged 1 commit into from
Jun 16, 2023

Conversation

NiklasEi
Copy link
Member

Objective

Solution

  • Added the window entity to KeyboardInput, MouseButtonInput, and MouseWheel events.

@NiklasEi NiklasEi added this to the 0.11 milestone Jun 15, 2023
@NiklasEi
Copy link
Member Author

Gave this the 0.11 milestone since the issue has it, too.

@alice-i-cecile alice-i-cecile added A-Input Player input via keyboard, mouse, gamepad, and more C-Usability A simple quality-of-life change that makes Bevy easier to use labels Jun 15, 2023
alice-i-cecile
alice-i-cecile approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very straightforward. LGTM.

@alice-i-cecile
Copy link
Member

@coderedart does this line up with what you originally needed? @mvlabat, if you have a moment, does this still make sense for bevy_egui?

@NiklasEi NiklasEi force-pushed the add_window_to_mouse_and_keyboard_events branch from 674ecee to c93ddf6 Compare June 15, 2023 20:18
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jun 16, 2023
@mvlabat
Copy link
Contributor

mvlabat commented Jun 16, 2023

@alice-i-cecile thank you for the ping! Oh yeah, absolutely. Currently, bevy_egui has to manage the state to remember a focused window itself, and we used to have some bugs related to it. This will definitely simplify things on our end

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 16, 2023
Merged via the queue into bevyengine:main with commit 84de9e7 Jun 16, 2023
@Aceeri Aceeri mentioned this pull request Jun 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@Aceeri Aceeri Aceeri approved these changes

Assignees
No one assigned
Labels
A-Input Player input via keyboard, mouse, gamepad, and more C-Usability A simple quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.11
Development

Successfully merging this pull request may close these issues.

MouseButton and KeyBoard events should contain WindowID
4 participants
@NiklasEi @alice-i-cecile @mvlabat @Aceeri