Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate indices for Mikktspace #8862

Merged
merged 8 commits into from
Sep 16, 2023
Merged

Conversation

robtfm
Copy link
Contributor

@robtfm robtfm commented Jun 16, 2023

Objective

mikktspace tangent generation requires mesh indices, and currently fails when they are not present. we can just generate them instead.

Solution

generate the indices.

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Usability A simple quality-of-life change that makes Bevy easier to use labels Jun 16, 2023
@JMS55
Copy link
Contributor

JMS55 commented Sep 14, 2023

Can we also get a generate_indices() function? For GPU-driven rendering or RT, assuming all meshes are indexed greatly simplifies things, so it makes sense to just generate an index buffer for meshes that are missing it for whatever reason.

@robtfm
Copy link
Contributor Author

robtfm commented Sep 14, 2023

Can we also get a generate_indices() function? For GPU-driven rendering or RT, assuming all meshes are indexed greatly simplifies things, so it makes sense to just generate an index buffer for meshes that are missing it for whatever reason.

could do. i'd think an accessor for attributes that uses the Option<Indices> to lookup into the raw data, or a function that gives an iterator over the index-ordered attribute data might be better to avoid the overhead of generating / storing indices, would either of those work for you?

@JMS55
Copy link
Contributor

JMS55 commented Sep 16, 2023

Yeah I think either would be fine. Doesn't have to be in this PR, or any time soon. It's something we can solve when we move to GPU-driven rendering.

@robtfm robtfm added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Sep 16, 2023
@mockersf mockersf added this pull request to the merge queue Sep 16, 2023
Merged via the queue into bevyengine:main with commit 9d23f82 Sep 16, 2023
22 checks passed
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
# Objective

mikktspace tangent generation requires mesh indices, and currently fails
when they are not present. we can just generate them instead.

## Solution

generate the indices.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Usability A simple quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants