Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "bevy_text" feature attributes on imports used by non-text systems #8907

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

ickshonpe
Copy link
Contributor

Objective

The "bevy_text" feature attributes for the PrimaryWindow, Window and TextureAtlas imports in bevy_ui::render are used by non-text systems (extract_uinode_borders and extract_atlas_uinodes) and need to be removed.

…indow` and `TextureAtlas` imports in `bevy_ui::render` as they are used by non-text systems.
@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-UI Graphical user interfaces, styles, layouts, and widgets labels Jun 20, 2023
@alice-i-cecile alice-i-cecile added this to the 0.11 milestone Jun 20, 2023
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jun 20, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 21, 2023
Merged via the queue into bevyengine:main with commit e529d8c Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants