Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix example grid #8940

Merged
merged 2 commits into from
Jun 23, 2023
Merged

fix example grid #8940

merged 2 commits into from
Jun 23, 2023

Conversation

Vrixyz
Copy link
Member

@Vrixyz Vrixyz commented Jun 23, 2023

Style flattened size, min_size and max_size to its root struct, causing compilation errors.

I uncommented the code to avoid further silent error not caught by CI, but hid the view to keep the same behaviour.

`Style` flattened `size`, `min_size` and `max_size` to its root struct,
causing compilation errors.
I uncommented the code to avoid further silent error not caught by CI, but hid the view to keep the same behaviour.
@Vrixyz Vrixyz added C-Examples An addition or correction to our examples C-Docs An addition or correction to our documentation A-UI Graphical user interfaces, styles, layouts, and widgets and removed C-Docs An addition or correction to our documentation labels Jun 23, 2023
examples/ui/grid.rs Outdated Show resolved Hide resolved
less confusing wording
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix! Great example of the dangers of commented out code.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jun 23, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 23, 2023
Merged via the queue into bevyengine:main with commit 469a19c Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants