-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework winit runner #9034
Draft
B-head
wants to merge
13
commits into
bevyengine:main
Choose a base branch
from
B-head:rework-winit-runner
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Rework winit runner #9034
Commits on Jun 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5685ec3 - Browse repository at this point
Copy the full SHA 5685ec3View commit details
Commits on Jun 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a919628 - Browse repository at this point
Copy the full SHA a919628View commit details -
Want to include `SubApp` in a system function, but `ExclusiveFunctionSystem` requires `Sync`.
Configuration menu - View commit details
-
Copy full SHA for e10458b - Browse repository at this point
Copy the full SHA e10458bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f210bed - Browse repository at this point
Copy the full SHA f210bedView commit details -
Replace
App::update()
toWorld::run_schedule()
Moved the responsibility for running top-level schedules from `App` struct to the runner function.
Configuration menu - View commit details
-
Copy full SHA for 91bb64d - Browse repository at this point
Copy the full SHA 91bb64dView commit details
Commits on Jul 3, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 28bcb95 - Browse repository at this point
Copy the full SHA 28bcb95View commit details
Commits on Jul 7, 2023
-
Separate tick rate and frame rate
Set `ControlFlow::WaitUntil` to the next tick update or redraw, whichever is closer. Prepare for changes in rust-windowing/winit#2900.
Configuration menu - View commit details
-
Copy full SHA for ede9e64 - Browse repository at this point
Copy the full SHA ede9e64View commit details -
Add resource to control winit runner
Send events for control from resource `WinitHandler`, which contains `EventLoopProxy`.
Configuration menu - View commit details
-
Copy full SHA for 0f21d9c - Browse repository at this point
Copy the full SHA 0f21d9cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 122a0d9 - Browse repository at this point
Copy the full SHA 122a0d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b3b5b5 - Browse repository at this point
Copy the full SHA 4b3b5b5View commit details -
The top schedule was redefined so that fine control would not be impossible. - Schedule `Main` was split into `StartupFlow` and `UpdateFlow`. - The names of the sub-schedules (`Startup`, `Update`, etc.) have not been changed, so in many cases no migration is necessary. - Add `Control` schedule. - Each time an event is received from windows and devices, this schedule is run. - This is useful for responding to events regardless of whether tick updates take place. - Add `FrameReady` schedule. - Each time a frame is ready to be updated, this schedule is run. - This is the best place to decide whether to redraw. - Rename `Render` schedule to `RenderFlow`. Schedules that run sub-schedules are now named uniformly as `***Flow`.
Configuration menu - View commit details
-
Copy full SHA for ebbfd6c - Browse repository at this point
Copy the full SHA ebbfd6cView commit details -
Configuration menu - View commit details
-
Copy full SHA for fe794a8 - Browse repository at this point
Copy the full SHA fe794a8View commit details
Commits on Jul 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 557408e - Browse repository at this point
Copy the full SHA 557408eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.