-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timer Polishing #931
Timer Polishing #931
Conversation
This is what I get for not pushing my own fixes :P |
@amberkowalski Oops, sorry! Did I miss anything? I'd be happy to add you as a collaborator on my fork, so you can push commits directly if you like. |
I can PR a timing example onto your fork if you don't mind, that's the main thing I was working on but had to fix some issues alongside it |
@amberkowalski Sounds great. I've invited you as a collaborator to my fork so you can push commits straight to this PR if you like, or you can chain your own PR. Whatever you like. 😄 |
Just added my example and some notice in the changelog! Hopefully it all worked okay since I used it as an opportunity to try out some fancy git commands and features :) |
Interesting, so bevy requires that you develop on nightly... |
Good work crew!
I dig it (for the reasons you mentioned). |
@amberkowalski @cart This is a followup to #914 -- I made
pause
functional, and polished up a couple other things I noticed:tick()
is called if currently paused.is_
prefixes.resume
tounpause
- this is somewhat arbitrary, but I feel it has better symmetry / discoverability when paired withpause
. Thoughts?