Make Anchor Copy

[nicopap]

Objective

In bevy_sprite, the Anchor type is not Copy. It makes interacting with it more difficult than necessary.

Solution

Derive Copy on it. The rust API guidelines are that you should derive Copy when possible. https://rust-lang.github.io/api-guidelines/interoperability.html#types-eagerly-implement-common-traits-c-common-traits
Regardless, Anchor is a very small enum which warrants Copy.

---

Changelog

• In bevy_sprite Anchor is now Copy.

[alice-i-cecile]

Definitely agree on Anchor, not totally sold on Sprite 🤔

[nicopap]

The one objection I can see for Sprite is that it might in the future hold a Handle<Image>. I find it unlikely.

Otherwise it's a 68 bytes struct where each field themselves are Copy. GlobalTransform is 64 bytes for comparison.

[james7132]

Definitely agree on Anchor, not totally sold on Sprite 🤔

I'm going to mirror this concern. Adding Copy changes the semantics of the type, and any changes to revert this is going to be a very painful breaking change. @cart has mentioned multiple times that types should be Copy within the codebase if and only if you can treat the type as values (i.e. Vec2, Transform), and I don't think Sprites logically meet this criteria.

[cart]

Yeah I agree that Sprite should not be copy. I removed that derive.