UI examples clean up #9479
Merged
UI examples clean up #9479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Root UI nodes have an implicit parent with `FlexDirection::Row` and `AlignItems::Stretch`. Setting `height: Val::Percent(100.)` isn't necessary to fill the viewport and can cause confusing overflow behaviour. * The default for position and size constraint properties is `Val::Auto`. Setting `left: Val::Auto`, `max_height: Val::Auto`, etc does nothing. Since the removed lines did nothing, there should be no change in the behaviour or appearance of any the examples.
|
Example |
ickshonpe
changed the title
alice-i-cecile
added
C-Examples
alice-i-cecile
approved these changes
Aug 19, 2023
nicoburns
approved these changes
Aug 22, 2023
This doesn't affect this PR, but IMO we really ought to try and change this to something more intuitive at some point. Perhaps root nodes should just actually be Taffy root nodes? |
alice-i-cecile
added
the
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fix a few issues with some of the examples:
Root UI nodes have an implicit parent with
FlexDirection::RowandAlignItems::Stretchset. Only a width constraint is needed to fill the viewport. Specifyingheight: Val::Percent(100.)is unnecessary and can cause confusing overflow behaviour.The default for position and size constraint properties is
Val::Auto. Settingleft: Val::Auto,max_height: Val::Auto, etc does nothing.Solution
Delete those lines. There should be no observable differences in the behaviours of any of the examples.
Also changed a padding setting in the
flex_layoutexample to use theaxeshelper function.