fix incorrect docs for JustifyItems and JustifySelf
#9539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
alice-i-cecile
added
C-Docs
nicoburns
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
This seems like a strict improvement on what we have. Although at some point we should probably modify the docs to account for the fact that Grid does use "main" and "cross" axis, and uses the same alignment properties to control the "block" and "inline" axis.
ickshonpe
approved these changes
Aug 22, 2023
Selene-Amanita
added
the
S-Ready-For-Final-Review
|
This is better but I think we should try to include examples with the docs for each variant. The terms "main" and "cross" axis aren't meaningful to most users. |
mockersf
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes incorrect docs in
bevy_uiforJustifyItemsandJustifySelf.Solution
JustifyItemsandJustifySelftarget the main axis and not the cross axis.