Run parent-update and transform-propagation during the "post-startup" stage (instead of "startup") #955
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Currently,
parent_update_system
andtransform_propagate_system
are registerd to run both at startup and for each update.When running for ecah update they are in the stage
POST_UPDATE
. It makes sense, because it make sure they run after potential creation/update ofTransform
that would happen during theUPDATE
stage.But when running at startup, these two systems were in the default (
STARTUP
) stage. So if the user spawn entities during that stage (which is very likely, since it's the default), then the entities spawned by the user may have a incorrectGlobalTransform
for the first update.This discrepency looks very much like a small mistake. I assume that, If it is correct to run these two system during the
POST_UPDATE
of each update, then the correct things to do at startup is to run during thePOST_STARTUP
.I hope it makes sense.
Thanks for this awseome work!