Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bevy_ui: reflect missing types #9677

Merged
merged 1 commit into from
Sep 2, 2023
Merged

bevy_ui: reflect missing types #9677

merged 1 commit into from
Sep 2, 2023

Conversation

SludgePhD
Copy link
Contributor

Register UiCameraConfig and UiTextureAtlasImage, and derive Reflect on UiScale and register that too.

@alice-i-cecile alice-i-cecile added A-UI Graphical user interfaces, styles, layouts, and widgets C-Usability A simple quality-of-life change that makes Bevy easier to use A-Reflection Runtime information about types labels Sep 2, 2023
@alice-i-cecile alice-i-cecile added this to the 0.12 milestone Sep 2, 2023
JMS55
JMS55 approved these changes Sep 2, 2023
View reviewed changes
Copy link
Contributor

@JMS55 JMS55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically needs a changelog

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Sep 2, 2023
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Sep 2, 2023
Merged via the queue into bevyengine:main with commit ea734ab Sep 2, 2023
26 checks passed
@SludgePhD SludgePhD deleted the reflect-ui branch September 2, 2023 21:24
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@SludgePhD
bevy_ui: reflect missing types (bevyengine#9677)
cad4584 
Register `UiCameraConfig` and `UiTextureAtlasImage`, and derive
`Reflect` on `UiScale` and register that too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@JMS55 JMS55 JMS55 approved these changes

Assignees
No one assigned
Labels
A-Reflection Runtime information about types A-UI Graphical user interfaces, styles, layouts, and widgets C-Usability A simple quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.12
Development

Successfully merging this pull request may close these issues.
3 participants
@SludgePhD @alice-i-cecile @JMS55