Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warn and min for different vertex count #9699

Merged
merged 5 commits into from
Sep 6, 2023
Merged

warn and min for different vertex count #9699

merged 5 commits into from
Sep 6, 2023

Conversation

robtfm
Copy link
Contributor

@robtfm robtfm commented Sep 5, 2023

Objective

Bevy currently crashes when meshes with different vertex counts for attributes are provided.

Solution

Instead of crashing we can warn and take the min length of all the given attributes.

@robtfm robtfm added A-Rendering Drawing game state to the screen P-Crash A sudden unexpected crash labels Sep 5, 2023
alice-i-cecile
alice-i-cecile requested changes Sep 5, 2023
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The # Panics doc strings on the method are no longer correct, and should be removed. In its place, we should describe the minimizing behavior.

@mockersf
Copy link
Member

mockersf commented Sep 5, 2023

docs of get_vertex_buffer_data should also get updated

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Sep 5, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Sep 5, 2023
Merged via the queue into bevyengine:main with commit 807d646 Sep 6, 2023
22 checks passed
@rparrett rparrett mentioned this pull request Oct 25, 2023
Closed
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@robtfm
warn and min for different vertex count (bevyengine#9699)
4844015 
# Objective

Bevy currently crashes when meshes with different vertex counts for
attributes are provided.

## Solution

Instead of crashing we can warn and take the min length of all the given
attributes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JMS55 JMS55 JMS55 left review comments

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@IceSentry IceSentry IceSentry approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen P-Crash A sudden unexpected crash S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@robtfm @mockersf @alice-i-cecile @IceSentry @JMS55