Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Text rendering / SharedBuffers #972

Merged
merged 2 commits into from
Dec 2, 2020
Merged

Optimize Text rendering / SharedBuffers #972

merged 2 commits into from
Dec 2, 2020

Conversation

cart
Copy link
Member

@cart cart commented Dec 2, 2020

This one isn't rocket science. Creating buffers every frame is really slow. We now actually share buffers in SharedBuffers. This was the intended design all along, I'm just now getting around to implementing it 😄

I used the text_debug example to benchmark.

Before:

Diagnostics:
---------------------------------------------------------------------------------------------
fps                                                              : 360.538804  (avg 362.820610)
frame_time                                                       : 0.002983    (avg 0.002756)

After

Diagnostics:
---------------------------------------------------------------------------------------------
fps                                                              : 1185.222059  (avg 1157.447952)
frame_time                                                       : 0.000818    (avg 0.000871)

@cart cart added C-Feature A new feature, making something new possible A-Rendering Drawing game state to the screen labels Dec 2, 2020
@cart cart changed the title optimize Text rendering / SharedBuffers Optimize Text rendering / SharedBuffers Dec 2, 2020
@cart
Copy link
Member Author

cart commented Dec 2, 2020

Minor bug with apps that don't use text. Easy fix.

@cart
Copy link
Member Author

cart commented Dec 2, 2020

Fixed!

@superdump superdump mentioned this pull request Dec 2, 2020
Merged
@cart cart merged commit ccb31bc into bevyengine:master Dec 2, 2020
@fopsdev fopsdev mentioned this pull request Jan 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Feature A new feature, making something new possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cart