Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase iteration count for asset tests #9737

Merged
merged 1 commit into from
Sep 10, 2023
Merged

Increase iteration count for asset tests #9737

merged 1 commit into from
Sep 10, 2023

Conversation

cart
Copy link
Member

@cart cart commented Sep 9, 2023

This needs to be much higher to avoid failures in CI. I don't love the "loop until" test methodology generally, but this is testing internal state and making this event driven would change the nature of the test.

@cart cart added A-Assets Load files from disk to use for things like images, models, and sounds C-Testing A change that impacts how we test Bevy or how users test their apps labels Sep 9, 2023
@alice-i-cecile alice-i-cecile added the A-Build-System Related to build systems or continuous integration label Sep 9, 2023
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Sep 10, 2023
@mockersf mockersf added this pull request to the merge queue Sep 10, 2023
Merged via the queue into bevyengine:main with commit 0c44de7 Sep 10, 2023
26 checks passed
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@cart
Increase iteration count for asset tests (bevyengine#9737)
4a57541 
This needs to be much higher to avoid failures in CI. I don't love the
"loop until" test methodology generally, but this is testing internal
state and making this event driven would change the nature of the test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-Assets Load files from disk to use for things like images, models, and sounds A-Build-System Related to build systems or continuous integration C-Testing A change that impacts how we test Bevy or how users test their apps S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cart @alice-i-cecile @mockersf