skybox.wgsl: Fix precision issues #9909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robtfm
reviewed
Sep 23, 2023
| 1.0, | ||
| 1.0 | ||
| ); | ||
| let view_position = view_position_homogeneous.xyz / view_position_homogeneous.w; |
There was a problem hiding this comment.
view_position_homogeneous.w is constant 1.0 from above
There was a problem hiding this comment.
Right, copy pasta.
There was a problem hiding this comment.
Actually no. This was wrong. The vec4 position is multiplied by the inverse projection matrix, so the resulting w is not guaranteed to be 1.0.
robtfm
approved these changes
Sep 23, 2023
JMS55
approved these changes
Sep 23, 2023
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
# Objective - Fixes bevyengine#9707 ## Solution - At large translations (a few thousand units), the precision of calculating the ray direction from the fragment world position and camera world position seems to break down. Sampling the cubemap only needs the ray direction. As such we can use the view space fragment position, normalise it, rotate it to world space, and use that. --- ## Changelog - Fixed: Jittery skybox at large translations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Changelog