Only attempt to copy resources that still exist from scenes #9984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
alice-i-cecile
added
C-Bug
alice-i-cecile
approved these changes
Oct 1, 2023
|
@alice-i-cecile, as in log a warning that we've hit this edge case? I don't think this represents any mistake from the consumer (IIUC a removed resource shouldn't be visible externally; we just keep the storage around as an optimisation). |
|
Yep, that was my intent. Great: I think I'm convinced by your argument here. |
mockersf
approved these changes
Oct 1, 2023
mockersf
added
the
S-Ready-For-Final-Review
james7132
approved these changes
Oct 2, 2023
ameknite
pushed a commit
to ameknite/bevy
that referenced
this pull request
Oct 3, 2023
…ne#9984) # Objective Avert a panic when removing resources from Scenes. ### Reproduction Steps ```rust let mut scene = Scene::new(World::default()); scene.world.init_resource::<Time>(); scene.world.remove_resource::<Time>(); scene.clone_with(&app.resource::<AppTypeRegistry>()); ``` ### Panic Message ``` thread 'Compute Task Pool (10)' panicked at 'Requested resource bevy_time::time::Time does not exist in the `World`. Did you forget to add it using `app.insert_resource` / `app.init_resource`? Resources are also implicitly added via `app.add_event`, and can be added by plugins.', .../bevy/crates/bevy_ecs/src/reflect/resource.rs:203:52 ``` ## Solution Check that the resource actually still exists before copying. --- ## Changelog - resolved a panic caused by removing resources from scenes
ameknite
pushed a commit
to ameknite/bevy
that referenced
this pull request
Oct 3, 2023
…ne#9984) # Objective Avert a panic when removing resources from Scenes. ### Reproduction Steps ```rust let mut scene = Scene::new(World::default()); scene.world.init_resource::<Time>(); scene.world.remove_resource::<Time>(); scene.clone_with(&app.resource::<AppTypeRegistry>()); ``` ### Panic Message ``` thread 'Compute Task Pool (10)' panicked at 'Requested resource bevy_time::time::Time does not exist in the `World`. Did you forget to add it using `app.insert_resource` / `app.init_resource`? Resources are also implicitly added via `app.add_event`, and can be added by plugins.', .../bevy/crates/bevy_ecs/src/reflect/resource.rs:203:52 ``` ## Solution Check that the resource actually still exists before copying. --- ## Changelog - resolved a panic caused by removing resources from scenes
regnarock
pushed a commit
to regnarock/bevy
that referenced
this pull request
Oct 13, 2023
…ne#9984) # Objective Avert a panic when removing resources from Scenes. ### Reproduction Steps ```rust let mut scene = Scene::new(World::default()); scene.world.init_resource::<Time>(); scene.world.remove_resource::<Time>(); scene.clone_with(&app.resource::<AppTypeRegistry>()); ``` ### Panic Message ``` thread 'Compute Task Pool (10)' panicked at 'Requested resource bevy_time::time::Time does not exist in the `World`. Did you forget to add it using `app.insert_resource` / `app.init_resource`? Resources are also implicitly added via `app.add_event`, and can be added by plugins.', .../bevy/crates/bevy_ecs/src/reflect/resource.rs:203:52 ``` ## Solution Check that the resource actually still exists before copying. --- ## Changelog - resolved a panic caused by removing resources from scenes
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
…ne#9984) # Objective Avert a panic when removing resources from Scenes. ### Reproduction Steps ```rust let mut scene = Scene::new(World::default()); scene.world.init_resource::<Time>(); scene.world.remove_resource::<Time>(); scene.clone_with(&app.resource::<AppTypeRegistry>()); ``` ### Panic Message ``` thread 'Compute Task Pool (10)' panicked at 'Requested resource bevy_time::time::Time does not exist in the `World`. Did you forget to add it using `app.insert_resource` / `app.init_resource`? Resources are also implicitly added via `app.add_event`, and can be added by plugins.', .../bevy/crates/bevy_ecs/src/reflect/resource.rs:203:52 ``` ## Solution Check that the resource actually still exists before copying. --- ## Changelog - resolved a panic caused by removing resources from scenes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Avert a panic when removing resources from Scenes.
Reproduction Steps
Panic Message
Solution
Check that the resource actually still exists before copying.
Changelog