chore: update tooling #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🌈Test ResultsNo files changed, compilation skipped 2024-11-22T08:10:55.197523Z ERROR cheatcodes: non-empty stderr input=["npx", "@bgd-labs/aave-cli@^1.1.12", "diff-snapshots", "./reports/AaveV3Arbitrum_GHOStewardV2Upgrade_20241007_before.json", "./reports/AaveV3Arbitrum_GHOStewardV2Upgrade_20241007_after.json", "-o", "./diffs/AaveV3Arbitrum_GHOStewardV2Upgrade_20241007_before_AaveV3Arbitrum_GHOStewardV2Upgrade_20241007_after.md"] stderr="npm warn exec The following package was not found and will be installed: @bgd-labs/aave-cli@1.1.12\n"Ran 9 tests for src/20241007_Multi_GHOStewardV2Upgrade/AaveV3Arbitrum_GHOStewardV2Upgrade_20241007.t.sol:AaveV3Arbitrum_GHOStewardV2Upgrade_20241007_Test [PASS] test_ghoAaveSteward_updateGhoBorrowRate() (gas: 522493) Ran 1 test suite in 16.50s (16.49s CPU time): 9 tests passed, 0 failed, 0 skipped (9 total tests) |
🔧 Build logsCompiling 351 files with Solc 0.8.20
Solc 0.8.20 finished in 172.54s
Compiler run successful with warnings:
Warning (5667): Unused function parameter. Remove or comment out the variable name to silence this warning.
--> lib/aave-helpers/src/swaps/AaveSwapper.sol:146:5:
|
146 | address erc20Token
| ^^^^^^^^^^^^^^^^^^
Warning (2018): Function state mutability can be restricted to pure
--> lib/aave-helpers/src/swaps/AaveSwapper.sol:145:3:
|
145 | function maxRescue(
| ^ (Relevant source part starts here and spans across multiple lines).
Warning (2018): Function state mutability can be restricted to pure
--> lib/aave-helpers/src/ProtocolV2TestBase.sol:663:3:
|
663 | function _logReserveConfig(ReserveConfig memory config) internal view {
| ^ (Relevant source part starts here and spans across multiple lines).
| Contract | Runtime Size (B) | Initcode Size (B) | Runtime Margin (B) | Initcode Margin (B) |
|---------------------------------------------------------------------------------------------|------------------|-------------------|--------------------|---------------------|
| AaveGovernanceV2 | 44 | 94 | 24,532 | 49,058 |
| AaveSafetyModule | 44 | 94 | 24,532 | 49,058 |
| AaveSwapper | 5,444 | 5,880 | 19,132 | 43,272 |
| AaveV2Avalanche | 44 | 94 | 24,532 | 49,058 |
| AaveV2AvalancheAssets | 44 | 94 | 24,532 | 49,058 |
| AaveV2Avalanche_ReserveFactorUpdatesMidOctober_20241004 | 988 | 1,017 | 23,588 | 48,135 |
| AaveV2Avalanche_UpdateLegacyGuardian_20241016 | 348 | 486 | 24,228 | 48,666 |
| AaveV2Ethereum | 44 | 94 | 24,532 | 49,058 |
| AaveV2EthereumAMM | 44 | 94 | 24,532 | 49,058 |
| AaveV2EthereumAMMAssets | 44 | 94 | 24,532 | 49,058 |
| AaveV2EthereumAMM_UpdateLegacyGuardian_20241016 | 348 | 486 | 24,228 | 48,666 |
| AaveV2EthereumAssets | 44 | 94 | 24,532 | 49,058 |
| AaveV2Ethereum_ReserveFactorUpdatesMidOctober_20241004 | 988 | 1,017 | 23,588 | 48,135 |
| AaveV2Ethereum_UpdateLegacyGuardian_20241016 | 348 | 486 | 24,228 | 48,666 |
| AaveV2Polygon | 44 | 94 | 24,532 | 49,058 |
| AaveV2PolygonAssets | 44 | 94 | 24,532 | 49,058 |
| AaveV2Polygon_ReserveFactorUpdatesMidOctober_20241004 | 2,384 | 2,454 | 22,192 | 46,698 |
| AaveV2Polygon_UpdateLegacyGuardian_20241016 | 348 | 486 | 24,228 | 48,666 |
| AaveV3Arbitrum | 44 | 94 | 24,532 | 49,058 |
| AaveV3ArbitrumAssets | 44 | 94 | 24,532 | 49,058 |
| AaveV3ArbitrumEModes | 44 | 94 | 24,532 | 49,058 |
| AaveV3ArbitrumExternalLibraries | 44 | 94 | 24,532 | 49,058 |
| AaveV3Arbitrum_GHOCCIP150Upgrade_20241021 | 817 | 846 | 23,759 | 48,306 |
| AaveV3Arbitrum_GHOStewardV2Upgrade_20241007 | 1,360 | 1,389 | 23,216 | 47,763 |
| AaveV3Arbitrum_ReserveFactorUpdatesMidOctober_20241004 | 3,227 | 3,297 | 21,349 | 45,855 |
| AaveV3Arbitrum_RiskStewardPhase2_20240805 | 307 | 336 | 24,269 | 48,816 |
| AaveV3Arbitrum_UpdateLegacyGuardian_20241016 | 1,062 | 1,393 | 23,514 | 47,759 |
| AaveV3Avalanche | 44 | 94 | 24,532 | 49,058 |
| AaveV3AvalancheAssets | 44 | 94 | 24,532 | 49,058 |
| AaveV3AvalancheEModes | 44 | 94 | 24,532 | 49,058 |
| AaveV3AvalancheExternalLibraries | 44 | 94 | 24,532 | 49,058 |
| AaveV3Avalanche_RiskStewardPhase2_20240805 | 178 | 206 | 24,398 | 48,946 |
| AaveV3Avalanche_UpdateLegacyGuardian_20241016 | 1,062 | 1,393 | 23,514 | 47,759 |
| AaveV3BNB | 44 | 94 | 24,532 | 49,058 |
| AaveV3BNBAssets | 44 | 94 | 24,532 | 49,058 |
| AaveV3BNBEModes | 44 | 94 | 24,532 | 49,058 |
| AaveV3BNBExternalLibraries | 44 | 94 | 24,532 | 49,058 |
| AaveV3BNB_OnboardWstETHToAaveV3OnBNBChain_20241030 | 5,561 | 5,632 | 19,015 | 43,520 |
| AaveV3BNB_RiskStewardPhase2_20240805 | 178 | 206 | 24,398 | 48,946 |
| AaveV3BNB_UpdateLegacyGuardian_20241016 | 1,062 | 1,393 | 23,514 | 47,759 |
| AaveV3Base | 44 | 94 | 24,532 | 49,058 |
| AaveV3BaseAssets | 44 | 94 | 24,532 | 49,058 |
| AaveV3BaseEModes | 44 | 94 | 24,532 | 49,058 |
| AaveV3BaseExternalLibraries | 44 | 94 | 24,532 | 49,058 |
| AaveV3Base_IncreaseCbBTCSupplyCaps_20241004 | 3,146 | 3,216 | 21,430 | 45,936 |
| AaveV3Base_ReserveFactorUpdatesMidOctober_20241004 | 3,223 | 3,293 | 21,353 | 45,859 |
| AaveV3Base_RiskStewardPhase2_20240805 | 178 | 206 | 24,398 | 48,946 |
| AaveV3Base_UpdateLegacyGuardian_20241016 | 1,062 | 1,393 | 23,514 | 47,759 |
| AaveV3Ethereum | 44 | 94 | 24,532 | 49,058 |
| AaveV3EthereumAssets | 44 | 94 | 24,532 | 49,058 |
| AaveV3EthereumEModes | 44 | 94 | 24,532 | 49,058 |
| AaveV3EthereumEtherFi | 44 | 94 | 24,532 | 49,058 |
| AaveV3EthereumEtherFiAssets | 44 | 94 | 24,532 | 49,058 |
| AaveV3EthereumEtherFiEModes | 44 | 94 | 24,532 | 49,058 |
| AaveV3EthereumEtherFiExternalLibraries | 44 | 94 | 24,532 | 49,058 |
| AaveV3EthereumEtherFi_RiskStewardPhase2_20240805 | 178 | 206 | 24,398 | 48,946 |
| AaveV3EthereumExternalLibraries | 44 | 94 | 24,532 | 49,058 |
| AaveV3EthereumLido | 44 | 94 | 24,532 | 49,058 |
| AaveV3EthereumLidoAssets | 44 | 94 | 24,532 | 49,058 |
| AaveV3EthereumLidoEModes | 44 | 94 | 24,532 | 49,058 |
| AaveV3EthereumLidoExternalLibraries | 44 | 94 | 24,532 | 49,058 |
| AaveV3EthereumLido_AutomatedAGRSActivation_20241108 | 3,046 | 3,075 | 21,530 | 46,077 |
| AaveV3EthereumLido_OnboardAndEnableSUSDeLiquidEModeOnAaveV3MainnetAndLidoInstances_20241108 | 5,657 | 5,728 | 18,919 | 43,424 |
| AaveV3EthereumLido_OnboardEzETHToLidoInstance_20241021 | 6,194 | 6,265 | 18,382 | 42,887 |
| AaveV3EthereumLido_RiskStewardPhase2_20240805 | 178 | 206 | 24,398 | 48,946 |
| AaveV3EthereumLido_WstETHSlope1UoptimalUpdate_20241001 | 3,250 | 3,320 | 21,326 | 45,832 |
| AaveV3Ethereum_AaveBGDPhase4_20241025 | 1,407 | 1,436 | 23,169 | 47,716 |
| AaveV3Ethereum_AaveCertoraContinuousSecurityServices_20241014 | 1,567 | 1,596 | 23,009 | 47,556 |
| AaveV3Ethereum_ChaosLabsAaveRiskManagementServiceRenewal_20241012 | 1,255 | 1,284 | 23,321 | 47,868 |
| AaveV3Ethereum_FixUSDSBorrowRateToMatchSkySavingsRate_20241022 | 3,238 | 3,308 | 21,338 | 45,844 |
| AaveV3Ethereum_GHOCCIP150Upgrade_20241021 | 817 | 846 | 23,759 | 48,306 |
| AaveV3Ethereum_GHOStewardV2Upgrade_20241007 | 2,895 | 2,924 | 21,681 | 46,228 |
| AaveV3Ethereum_IncreaseCbBTCSupplyCaps_20241004 | 3,150 | 3,220 | 21,426 | 45,932 |
| AaveV3Ethereum_IncreaseUSDSBorrowRateToMatchSkySavingsRate_20241016 | 3,239 | 3,309 | 21,337 | 45,843 |
| AaveV3Ethereum_OnboardAndEnableSUSDeLiquidEModeOnAaveV3MainnetAndLidoInstances_20241108 | 3,817 | 3,887 | 20,759 | 45,265 |
| AaveV3Ethereum_OnboardRsETHToAaveV3Ethereum_20241104 | 5,957 | 6,028 | 18,619 | 43,124 |
| AaveV3Ethereum_PYUSDReserveConfigurationUpdateIncentiveCampaign_20241031 | 3,988 | 4,059 | 20,588 | 45,093 |
| AaveV3Ethereum_RemoveFraxFromIsolationModeOnAaveV3Mainnet_20241105 | 3,226 | 3,296 | 21,350 | 45,856 |
| AaveV3Ethereum_RenewLlamaRiskAsRiskServiceProvider_20241013 | 1,068 | 1,097 | 23,508 | 48,055 |
| AaveV3Ethereum_RiskStewardPhase2_20240805 | 307 | 336 | 24,269 | 48,816 |
| AaveV3Ethereum_SafetyModuleStkAAVEReEnableRewards_20241106 | 910 | 939 | 23,666 | 48,213 |
| AaveV3Ethereum_StkGHOIncentivesQ4_20241029 | 1,458 | 1,487 | 23,118 | 47,665 |
| AaveV3Ethereum_UpdateLegacyGuardian_20241016 | 1,062 | 1,413 | 23,514 | 47,739 |
| AaveV3Ethereum_WstETHReserveBorrowRateUpdateMainInstance_20241024 | 3,227 | 3,297 | 21,349 | 45,855 |
| AaveV3Gnosis | 44 | 94 | 24,532 | 49,058 |
| AaveV3GnosisAssets | 44 | 94 | 24,532 | 49,058 |
| AaveV3GnosisEModes | 44 | 94 | 24,532 | 49,058 |
| AaveV3GnosisExternalLibraries | 44 | 94 | 24,532 | 49,058 |
| AaveV3Gnosis_ReserveFactorUpdatesMidOctober_20241004 | 3,225 | 3,295 | 21,351 | 45,857 |
| AaveV3Gnosis_RiskStewardPhase2_20240805 | 178 | 206 | 24,398 | 48,946 |
| AaveV3Gnosis_UpdateLegacyGuardian_20241016 | 1,062 | 1,393 | 23,514 | 47,759 |
| AaveV3Metis | 44 | 94 | 24,532 | 49,058 |
| AaveV3MetisAssets | 44 | 94 | 24,532 | 49,058 |
| AaveV3MetisEModes | 44 | 94 | 24,532 | 49,058 |
| AaveV3MetisExternalLibraries | 44 | 94 | 24,532 | 49,058 |
| AaveV3Metis_RiskStewardPhase2_20240805 | 178 | 206 | 24,398 | 48,946 |
| AaveV3Metis_UpdateLegacyGuardian_20241016 | 1,062 | 1,393 | 23,514 | 47,759 |
| AaveV3Optimism | 44 | 94 | 24,532 | 49,058 |
| AaveV3OptimismAssets | 44 | 94 | 24,532 | 49,058 |
| AaveV3OptimismEModes | 44 | 94 | 24,532 | 49,058 |
| AaveV3OptimismExternalLibraries | 44 | 94 | 24,532 | 49,058 |
| AaveV3Optimism_ReserveFactorUpdatesMidOctober_20241004 | 3,227 | 3,297 | 21,349 | 45,855 |
| AaveV3Optimism_RiskStewardPhase2_20240805 | 178 | 206 | 24,398 | 48,946 |
| AaveV3Optimism_UpdateLegacyGuardian_20241016 | 1,062 | 1,393 | 23,514 | 47,759 |
| AaveV3Polygon | 44 | 94 | 24,532 | 49,058 |
| AaveV3PolygonAssets | 44 | 94 | 24,532 | 49,058 |
| AaveV3PolygonEModes | 44 | 94 | 24,532 | 49,058 |
| AaveV3PolygonExternalLibraries | 44 | 94 | 24,532 | 49,058 |
| AaveV3Polygon_ReserveFactorUpdatesMidOctober_20241004 | 3,226 | 3,296 | 21,350 | 45,856 |
| AaveV3Polygon_RiskStewardPhase2_20240805 | 178 | 206 | 24,398 | 48,946 |
| AaveV3Polygon_UpdateLegacyGuardian_20241016 | 1,062 | 1,393 | 23,514 | 47,759 |
| AaveV3Scroll | 44 | 94 | 24,532 | 49,058 |
| AaveV3ScrollAssets | 44 | 94 | 24,532 | 49,058 |
| AaveV3ScrollEModes | 44 | 94 | 24,532 | 49,058 |
| AaveV3ScrollExternalLibraries | 44 | 94 | 24,532 | 49,058 |
| AaveV3Scroll_RiskStewardPhase2_20240805 | 178 | 206 | 24,398 | 48,946 |
| AaveV3Scroll_UpdateLegacyGuardian_20241016 | 1,062 | 1,393 | 23,514 | 47,759 |
| Address | 44 | 94 | 24,532 | 49,058 |
| CCIPUtils | 4,968 | 5,021 | 19,608 | 44,131 |
| ChainHelpers | 44 | 94 | 24,532 | 49,058 |
| ChainIds | 44 | 94 | 24,532 | 49,058 |
| Client | 109 | 160 | 24,467 | 48,992 |
| CollectorUtils | 44 | 94 | 24,532 | 49,058 |
| ConfiguratorInputTypes | 44 | 94 | 24,532 | 49,058 |
| Create2Utils | 121 | 172 | 24,455 | 48,980 |
| Create2UtilsZkSync | 104 | 155 | 24,472 | 48,997 |
| DataTypes | 44 | 94 | 24,532 | 49,058 |
| ERC1967Proxy | 122 | 967 | 24,454 | 48,185 |
| ERC1967Utils | 44 | 94 | 24,532 | 49,058 |
| EngineFlags | 44 | 94 | 24,532 | 49,058 |
| Errors | 4,652 | 4,705 | 19,924 | 44,447 |
| GovV3Helpers | 2,517 | 2,570 | 22,059 | 46,582 |
| GovV3StorageHelpers | 44 | 94 | 24,532 | 49,058 |
| GovernanceGuardians | 292 | 345 | 24,284 | 48,807 |
| GovernanceV3Arbitrum | 44 | 94 | 24,532 | 49,058 |
| GovernanceV3Avalanche | 44 | 94 | 24,532 | 49,058 |
| GovernanceV3BNB | 44 | 94 | 24,532 | 49,058 |
| GovernanceV3Base | 44 | 94 | 24,532 | 49,058 |
| GovernanceV3Ethereum | 44 | 94 | 24,532 | 49,058 |
| GovernanceV3Gnosis | 44 | 94 | 24,532 | 49,058 |
| GovernanceV3Metis | 44 | 94 | 24,532 | 49,058 |
| GovernanceV3Optimism | 44 | 94 | 24,532 | 49,058 |
| GovernanceV3Polygon | 44 | 94 | 24,532 | 49,058 |
| GovernanceV3PolygonZkEvm | 44 | 94 | 24,532 | 49,058 |
| GovernanceV3Scroll | 44 | 94 | 24,532 | 49,058 |
| GovernanceV3ZkSync | 44 | 94 | 24,532 | 49,058 |
| IpfsUtils | 44 | 94 | 24,532 | 49,058 |
| MiscArbitrum | 44 | 94 | 24,532 | 49,058 |
| MiscAvalanche | 44 | 94 | 24,532 | 49,058 |
| MiscBNB | 44 | 94 | 24,532 | 49,058 |
| MiscBase | 44 | 94 | 24,532 | 49,058 |
| MiscEthereum | 44 | 94 | 24,532 | 49,058 |
| MiscGnosis | 44 | 94 | 24,532 | 49,058 |
| MiscMetis | 44 | 94 | 24,532 | 49,058 |
| MiscOptimism | 44 | 94 | 24,532 | 49,058 |
| MiscPolygon | 44 | 94 | 24,532 | 49,058 |
| MiscScroll | 44 | 94 | 24,532 | 49,058 |
| Payloads | 44 | 94 | 24,532 | 49,058 |
| PayloadsControllerUtils | 44 | 94 | 24,532 | 49,058 |
| ProtocolGuardians | 292 | 345 | 24,284 | 48,807 |
| ProxyAdmin | 990 | 1,235 | 23,586 | 47,917 |
| ProxyHelpers | 44 | 94 | 24,532 | 49,058 |
| RateLimiter | 44 | 94 | 24,532 | 49,058 |
| RenewalV2BasePayload | 348 | 595 | 24,228 | 48,557 |
| RenewalV3BasePayload | 1,062 | 1,509 | 23,514 | 47,643 |
| ReserveConfiguration | 128 | 179 | 24,448 | 48,973 |
| RewardsDataTypes | 44 | 94 | 24,532 | 49,058 |
| SafeCast | 44 | 94 | 24,532 | 49,058 |
| SafeERC20 | 44 | 94 | 24,532 | 49,058 |
| StorageHelpers | 44 | 94 | 24,532 | 49,058 |
| StorageSlot | 44 | 94 | 24,532 | 49,058 |
| TestNetChainIds | 44 | 94 | 24,532 | 49,058 |
| TransparentUpgradeableProxy | 1,088 | 2,274 | 23,488 | 46,878 |
| WadRayMath | 44 | 94 | 24,532 | 49,058 |🔧 Build logs zksyncCompiling 110 files with zksolc and ZKsync solc 0.8.20
zksolc and ZKsync solc 0.8.20 finished in 75.51s
Compiler run successful!
| Contract | Runtime Size (B) | Initcode Size (B) | Runtime Margin (B) | Initcode Margin (B) |
|----------|------------------|-------------------|--------------------|---------------------| |
kyzia551
approved these changes
Nov 22, 2024
DhairyaSethi
added a commit
to aave/aave-proposals-v3
that referenced
this pull request
Dec 25, 2024
DhairyaSethi
pushed a commit
to aave/aave-proposals-v3
that referenced
this pull request
Dec 25, 2024
**BREAKING CHANGES**: - updates to a new version of **catapulta-verify** which relies on etherscan api v2 and generalizes the routescan verification. Please add a `ETHERSCAN_API_KEY` without any network suffix to your `.env`. This new version should be more reliable and support a bigger set of networks. - new version of origin and `aave-cli`. Please run `npm i` to update. The new version will no longer generate IRs inside `.assets/`, but instead inline an image link, which in theory could also be embedded in aips.
DhairyaSethi
added a commit
to aave/aave-proposals-v3
that referenced
this pull request
Dec 25, 2024
brotherlymite
pushed a commit
that referenced
this pull request
Jan 16, 2025
* Add proposal for Gho Incident Report 20231113 (#1) * chore: add payload and deploy script for update of GHO variable debt token * forge install: gho-core * chore: add gho-core to dependency * test: Add tests for update of gho variable token * test: Add tests for update of gho variable token * fix: add modifier in method of interface * fix: remove gho dependency from repo and fix test * fix: Remove unnecesary dependency * fix: Add latest details --------- Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com> * fix: Make new impl constant (#3) * fix: Amend AIP text (#4) * fix: Make new impl constant * fix: Fix AIP text * test: Tweak default tests with borrow cap update (#5) * fix: lint issue (#6) * test: Add diffs from test running (#7) * fix: Add payload address (#8) * fix: Fix payload address in script (#9) * fix: Remove unneeded diff file (#10) * chore: init aip * feat: ccip 1.5.1 upgrade * tmp: fix ci for aave org, to rm for bdg * tmp: add 1.4 pool with withdrawLiq flattended, to be removed once impl is deployed * tmp: fix ci for aave org * revert: test ci secrets updates * chore: fix comments * chore: rm duplicate check * chore: reorder imports, pending automation * chore: import order * chore: imports order, re-frame comment * feat: update to latest spec: naming changes, setCurrentBridgedAmount, resolve existing pool bridgeAmount comment * chore: consistency, cleanup comment based on latest approach * upd: `directMint` & `directBurn` * feat: add `gho-core` lib temporarily, fix interface * feat: new gho ccip steward * feat: reference existing pool upgrade impl deployment * feat: more verbose and efficient * chore: upd ccip lib * test: cleanup & fuzzify * test: cleanup & fuzzify * chore: use latest deployment of existing remote pool upgrade * doc: snapshot -> direct-to-aip * chore: import gho from EthereumAssets instead of MiscEthereum * chore: cleanup rm ProxyAdmin reference * chore: rename facilitator * chore: rm duplicate check * fix: updates based on upstream changes from #527 * chore: fix&add comment, use chain selector from helper lib * chore: fix chain selector lib typo * feat: accept existing proxy pool ownership as well * feat: add rate limit * feat: add deployed token pools & stewards * feat: rm `gho-core` & `ccip` * feat: upd arb token pool & steward deployment * feat: notify gho bucket steward * feat: update aave steward * chore: use existing IOwnable * chore: new ccip stewards with timelock getter * feat: use oz v5.1 proxies * doc: add discussion + spec * feat: chainlink pre-req have been performed * Updated GHOCCIP151Upgrade.md * Updated GHOCCIP151Upgrade.md Updated to permalinks * doc: lint and add steward addresses to spec md * doc: expand on bucket steward update --------- Co-authored-by: Parth Patel <parth4321patel@gmail.com> Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com> Co-authored-by: miguelmtz <36620902+miguelmtzinf@users.noreply.github.com> Co-authored-by: JP <89362795+CanonicalJP@users.noreply.github.com>
sakulstra
pushed a commit
that referenced
this pull request
Feb 5, 2025
* Add proposal for Gho Incident Report 20231113 (#1) * chore: add payload and deploy script for update of GHO variable debt token * forge install: gho-core * chore: add gho-core to dependency * test: Add tests for update of gho variable token * test: Add tests for update of gho variable token * fix: add modifier in method of interface * fix: remove gho dependency from repo and fix test * fix: Remove unnecesary dependency * fix: Add latest details --------- Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com> * fix: Make new impl constant (#3) * fix: Amend AIP text (#4) * fix: Make new impl constant * fix: Fix AIP text * test: Tweak default tests with borrow cap update (#5) * fix: lint issue (#6) * test: Add diffs from test running (#7) * fix: Add payload address (#8) * fix: Fix payload address in script (#9) * fix: Remove unneeded diff file (#10) * chore: init aip * feat: ccip 1.5.1 upgrade * tmp: fix ci for aave org, to rm for bdg * tmp: add 1.4 pool with withdrawLiq flattended, to be removed once impl is deployed * tmp: fix ci for aave org * revert: test ci secrets updates * chore: fix comments * chore: rm duplicate check * chore: reorder imports, pending automation * chore: import order * chore: imports order, re-frame comment * feat: update to latest spec: naming changes, setCurrentBridgedAmount, resolve existing pool bridgeAmount comment * chore: consistency, cleanup comment based on latest approach * upd: `directMint` & `directBurn` * feat: add `gho-core` lib temporarily, fix interface * feat: new gho ccip steward * feat: reference existing pool upgrade impl deployment * feat: more verbose and efficient * feat: base expansion * chore: upd ccip lib * test: cleanup & fuzzify * test: cleanup & fuzzify * chore: use latest deployment of existing remote pool upgrade * doc: snapshot -> direct-to-aip * chore: import gho from EthereumAssets instead of MiscEthereum * chore: cleanup rm ProxyAdmin reference * chore: rename facilitator * chore: rm duplicate check * fix: updates based on upstream changes from #527 * chore: fix&add comment, use chain selector from helper lib * chore: upd ccip lib * feat: expand _validateConfig in e2e test * feat: eth & arb tests * chore: import gho from EthereumAssets instead of MiscEthereum * chore: use latest deployment of existing remote pool upgrade * doc: snapshot & discussion * chore: rename facilitator * test: cleanup & fuzzify * test: cleanup & fuzzify * chore: use latest deployment of existing remote pool upgrade * doc: snapshot -> direct-to-aip * chore: import gho from EthereumAssets instead of MiscEthereum * chore: cleanup rm ProxyAdmin reference * chore: rename facilitator * chore: rm duplicate check * fix: snapshot, use utils reference for chain selectors * fix: base config test on eth * test: eth<>arb e2e test * chore: mock naming accuracy * feat: base token through create2 * feat: expand _validateConfig in e2e test * feat: use deployed gho token impl on base, fix facilitator bucket to 20M instead of 25M * fix: merge latest upstream * chore: fix chain selector lib typo * fix: tmp fix remappings such that gho-core OZ and aave-v3 OZ do not collide * feat: stewards, base tests * fix: use 500 maxChange borrowRateConfig * feat: validate base proposal constants * chore: add partial explorer links for immutables * test: tokenPoolConfig * feat: accept existing proxy pool ownership as well * feat: add rate limit * test: fix risk council * fix: merge * feat: add rate limit * fix: riskCouncil * feat: gho base listing * feat: aave stewards test * chore: fix typo * chore: upd title * feat: add deployed token pools & stewards * feat: rm `gho-core` & `ccip` * feat: upd arb token pool & steward deployment * feat: use deployed base token pool & stewards * feat: notify gho bucket steward * feat: update aave steward * upd: upstream * chore: use existing IOwnable * chore: steward tests * fix: ccip stewards tests * test: listing pre-req negative cases * chore: minor cleanup * test: verbose error msg * feat: QoL cleanup * chore: new ccip stewards with timelock getter * chore: upd upstream * chore: new ccip stewards with timelock getter on base * feat: use oz v5.1 proxies * upd: use latest eth/arb deployments * feat: predeploy gho token * doc: upd md with new token * feat: update gho token proxyAdmin * test: simplify * chore: minor cleanup nits * chore: resolve conflicts * fix: update blocks, cleanup on pre-requisites * doc: update AIP text * test: 1.5.1 upgrade executed on chain, rm all prerequisites in tests * test: upd base block since all pre req are complete * chore: update spec md Co-authored-by: Ian Flexa <85500650+ianflexa@users.noreply.github.com> * fix: generate diff md again * Add proposal for Gho Incident Report 20231113 (#1) * chore: add payload and deploy script for update of GHO variable debt token * forge install: gho-core * chore: add gho-core to dependency * test: Add tests for update of gho variable token * test: Add tests for update of gho variable token * fix: add modifier in method of interface * fix: remove gho dependency from repo and fix test * fix: Remove unnecesary dependency * fix: Add latest details --------- Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com> * fix: Make new impl constant (#3) * fix: Amend AIP text (#4) * fix: Make new impl constant * fix: Fix AIP text * test: Tweak default tests with borrow cap update (#5) * fix: lint issue (#6) * test: Add diffs from test running (#7) * fix: Add payload address (#8) * fix: Fix payload address in script (#9) * fix: Remove unneeded diff file (#10) * fix: rebase and update diffs, imports * chore: import token pools from address book * chore: fix lint on spec md * fix: update rates based on latest recc --------- Co-authored-by: Parth Patel <parth4321patel@gmail.com> Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com> Co-authored-by: miguelmtz <36620902+miguelmtzinf@users.noreply.github.com> Co-authored-by: Ian Flexa <85500650+ianflexa@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES:
updates to a new version of catapulta-verify which relies on etherscan api v2 and generalizes the routescan verification. Please add a
ETHERSCAN_API_KEYwithout any network suffix to your.env. This new version should be more reliable and support a bigger set of networks.new version of origin and
aave-cli. Please runnpm ito update. The new version will no longer generate IRs inside.assets/, but instead inline an image link, which in theory could also be embedded in aips.