chore: update tooling

.env.example

@@ -6,22 +6,25 @@ LEDGER_SENDER=
 PRIVATE_KEY=
 
 # Test rpc_endpoints
-RPC_MAINNET=https://eth.llamarpc.com
-RPC_AVALANCHE=https://api.avax.network/ext/bc/C/rpc
-RPC_OPTIMISM=https://optimism.llamarpc.com
-RPC_POLYGON=https://polygon.llamarpc.com
-RPC_ARBITRUM=https://arbitrum.llamarpc.com
-RPC_FANTOM=https://rpc.ftm.tools
-RPC_HARMONY=https://api.harmony.one
-RPC_METIS=https://andromeda.metis.io/?owner=1088
-RPC_BASE=https://base.llamarpc.com
-RPC_ZKEVM=https://zkevm-rpc.com
-RPC_GNOSIS=https://rpc.ankr.com/gnosis
-RPC_BNB=https://binance.llamarpc.com
-RPC_SCROLL=https://rpc.scroll.io
-RPC_ZKSYNC=https://mainnet.era.zksync.io
+# To generate RPCs based on you api keys, you can use
+# export ALCHEMY_API_KEY=yourAlchemyKey && npx @bgd-labs/rpc-env
+RPC_MAINNET=
+RPC_AVALANCHE=
+RPC_OPTIMISM=
+RPC_POLYGON=
+RPC_ARBITRUM=
+RPC_FANTOM=
+RPC_HARMONY=
+RPC_METIS=
+RPC_BASE=
+RPC_ZKEVM=
+RPC_GNOSIS=
+RPC_BNB=
+RPC_SCROLL=
+RPC_ZKSYNC=
 
 # Etherscan api keys for verification & download utils
+# Dedicated api keys for each chain are required when using foundry verification
 ETHERSCAN_API_KEY_MAINNET=
 ETHERSCAN_API_KEY_POLYGON=
 ETHERSCAN_API_KEY_AVALANCHE=
@@ -35,6 +38,9 @@ ETHERSCAN_API_KEY_BNB=
 ETHERSCAN_API_KEY_SCROLL=
 ETHERESCAN_API_KEY_ZKSYNC=
 
+# Catapulta verify uses etherscan v2 api, therefore adding a single api key is good enough
+ETHERSCAN_API_KEY=
+
 # Simulation/fork creation
 TENDERLY_ACCESS_TOKEN=
 TENDERLY_ACCOUNT=

.github/workflows/comment.yml

@@ -9,4 +9,5 @@ on:
 jobs:
   test:
     uses: bgd-labs/github-workflows/.github/workflows/comment.yml@main
-    secrets: inherit
+    secrets:
+      READ_ONLY_PAT: ${{ secrets.READ_ONLY_PAT }}

.github/workflows/test.yml

@@ -65,4 +65,3 @@ jobs:
 
   test-js:
     uses: bgd-labs/github-workflows/.github/workflows/test-node.yml@main
-    secrets: inherit

README.md

@@ -107,7 +107,8 @@ If for whatever reason verification fails, there's a good chance the error is on
 To retry a specific verification you can follow the following steps:
 
 1. copy verify.example.json to verify.json
-2. replace the `chain` with the appropriate chainId
-3. replace the `hash` with the transaction hash of the deployment transaction (make sure it's the deployment transaction, not the one registering the payload on the payloadscontroller)
-4. run `FOUNDRY_PROFILE=<chainAlias> forge build --force`
-5. run `FOUNDRY_PROFILE=<chainAlias> npx catapulta-verify -b verify.json`
+2. enter an `ETHERSCAN_API_KEY` in your `.env`
+3. replace the `chain` with the appropriate chainId
+4. replace the `hash` with the transaction hash of the deployment transaction (make sure it's the deployment transaction, not the one registering the payload on the payloadscontroller)
+5. run `FOUNDRY_PROFILE=<chainAlias> forge build --force`
+6. run `FOUNDRY_PROFILE=<chainAlias> npx catapulta-verify -b verify.json`