Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name pipes in Windows 7 #1

Merged
merged 1 commit into from
Aug 7, 2020
Merged

Fix name pipes in Windows 7 #1

merged 1 commit into from
Aug 7, 2020

Conversation

yalegko
Copy link
Member

@yalegko yalegko commented Aug 7, 2020

dup microsoft#174

microsoft#173
Accept() blocks forever on Windows7, and all tests that rely on Accept() returning fail on Windows 7.
This commit broke it: bd71ef0
Windows 7 is behaving differently than Win10.
The fix is a workaround that used to exist before the breaking commit. I have re-introduced the client connect to ensure pipe instance is created. Not sure if there is a better fix.
Also, fixed a couple of tests which were failing on Windows 7.

@yalegko yalegko merged commit cbf287a into bi-zone:master Aug 7, 2020
@iwind
Copy link

iwind commented Aug 17, 2020

Thank you, it solved my issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants