fixes for Windows 7 #174
Closed
fixes for Windows 7 #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#173
Accept() blocks forever on Windows7, and all tests that rely on Accept() returning fail on Windows 7.
This commit broke it: bd71ef0
Windows 7 is behaving differently than Win10.
The fix is a workaround that used to exist before the breaking commit. I have re-introduced the client connect to ensure pipe instance is created. Not sure if there is a better fix.
Also, fixed a couple of tests which were failing on Windows 7.