Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] IntendedFor in (i)EEG is dataset relative #1093

Merged
merged 3 commits into from
May 2, 2022
Merged

[FIX] IntendedFor in (i)EEG is dataset relative #1093

merged 3 commits into from
May 2, 2022

Conversation

sappelhoff
Copy link
Member

@sappelhoff sappelhoff commented Apr 25, 2022 •
edited
Loading

@sappelhoff sappelhoff added MEG Magnetoencephalography iEEG EEG Electroencephalography schema Issues related to the YAML schema representation of the specification. Patch version release. labels Apr 25, 2022
@sappelhoff sappelhoff requested a review from tsalo as a code owner April 25, 2022 10:35
@codecov
Copy link

codecov bot commented Apr 25, 2022 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.71%. Comparing base (a4a03dd) to head (15b4e7f).
Report is 1102 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1093      +/-   ##
==========================================
+ Coverage   70.75%   71.71%   +0.96%     
==========================================
  Files           9        9              
  Lines         937      937              
==========================================
+ Hits          663      672       +9     
+ Misses        274      265       -9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sappelhoff
sappelhoff commented Apr 26, 2022
View reviewed changes
Copy link
Member Author

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tsalo is the way I deal with the schema here fine?

This was referenced Apr 26, 2022
Closed
Closed
@tsalo
Copy link
Member

tsalo commented Apr 29, 2022

It looks good to me. I would have recommended __ieeg, but it looks like this applies to both iEEG and EEG, so I don't see a clear modality-specific suffix. __ds_relative is definitely clear.

tsalo
tsalo approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sappelhoff sappelhoff merged commit b2cf0ff into bids-standard:master May 2, 2022
@sappelhoff sappelhoff deleted the fix/eegieeg/intendedfor branch May 2, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsalo tsalo tsalo approved these changes

Assignees
No one assigned
Labels
EEG Electroencephalography iEEG MEG Magnetoencephalography schema Issues related to the YAML schema representation of the specification. Patch version release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incoherent IntendedFor definitions Specification of AssociatedEmptyRoom
2 participants
@sappelhoff @tsalo