[FIX] clarify that string is expected for HowToAcknowledge field in dataset_description.json #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwblair
previously approved these changes
Dec 9, 2019
effigies
previously approved these changes
Dec 9, 2019
teonbrooks
reviewed
Dec 10, 2019
@teonbrooks @emdupre yes, that's also what I prefer, see: #372 (comment) However, that was not the original goal of the issue and associated PR. We have a separate issue already discussing this (see #350). And in my final comment #372 (comment) I asked to "divide and conquer" to make faster progress :-) |
effigies
reviewed
Dec 10, 2019
teonbrooks
previously approved these changes
Dec 10, 2019
Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
sappelhoff
dismissed stale reviews from teonbrooks, effigies, and rwblair
via
b405331
franklin-feingold
added a commit
that referenced
this pull request
Dec 11, 2019
satra
added a commit
to satra/bids-specification
that referenced
this pull request
Feb 7, 2020
* upstream/master: (439 commits) [DOC] Auto-generate changelog entry for PR bids-standard#394 Update 01-contributors.md [DOC] Auto-generate changelog entry for PR bids-standard#389 [DOC] Auto-generate changelog entry for PR bids-standard#386 moved list of extension proposals to the main BIDS website section 06-extensions remains, but now points to the main website Typo fix for typo fix Typo fix for typo fix [DOC] Auto-generate changelog entry for PR bids-standard#374 [FIX] Fix some typos and prose style issues [DOC] Auto-generate changelog entry for PR bids-standard#383 restructure according to @emdupre's proposal neurostars for everything not just technical Apply suggestions from code review MNT: Update Pipfile ENH: Append CSS instead of overriding it ENH: Add watermark to drafts [DOC] Auto-generate changelog entry for PR bids-standard#381 Update src/06-extensions.md Retiring moderator duties for BEP021 [DOC] Auto-generate changelog entry for PR bids-standard#380 ...
satra
added a commit
to satra/bids-specification
that referenced
this pull request
Feb 7, 2020
* upstream/master: (439 commits) [DOC] Auto-generate changelog entry for PR bids-standard#394 Update 01-contributors.md [DOC] Auto-generate changelog entry for PR bids-standard#389 [DOC] Auto-generate changelog entry for PR bids-standard#386 moved list of extension proposals to the main BIDS website section 06-extensions remains, but now points to the main website Typo fix for typo fix Typo fix for typo fix [DOC] Auto-generate changelog entry for PR bids-standard#374 [FIX] Fix some typos and prose style issues [DOC] Auto-generate changelog entry for PR bids-standard#383 restructure according to @emdupre's proposal neurostars for everything not just technical Apply suggestions from code review MNT: Update Pipfile ENH: Append CSS instead of overriding it ENH: Add watermark to drafts [DOC] Auto-generate changelog entry for PR bids-standard#381 Update src/06-extensions.md Retiring moderator duties for BEP021 [DOC] Auto-generate changelog entry for PR bids-standard#380 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #372
@rwblair once this is merged, we can adjust the validator so that it only accepts string for the
HowToAcknowledgefield indataset_description.json.