-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INFRA] Add watermark to drafts #383
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a very well implemented and easy to maintain solution. Thanks a lot @effigies.
re: style --> I like how it is: It's an obvious marker with the combination of watermark AND colorchange
re: more styles --> I think that one style is enough and that (at least currently) we don't need more styles. In the future, this would boil down to simply adding a CSS file and adjusting a line for your mkdocs plugin, right?
Yes. Something like:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks awesome!
Cool. Thanks for the reviews. I'll go ahead and merge so I can include it in |
Actually, I think that what I described above would work on any tag except ones that are on the latest |
* upstream/master: (439 commits) [DOC] Auto-generate changelog entry for PR bids-standard#394 Update 01-contributors.md [DOC] Auto-generate changelog entry for PR bids-standard#389 [DOC] Auto-generate changelog entry for PR bids-standard#386 moved list of extension proposals to the main BIDS website section 06-extensions remains, but now points to the main website Typo fix for typo fix Typo fix for typo fix [DOC] Auto-generate changelog entry for PR bids-standard#374 [FIX] Fix some typos and prose style issues [DOC] Auto-generate changelog entry for PR bids-standard#383 restructure according to @emdupre's proposal neurostars for everything not just technical Apply suggestions from code review MNT: Update Pipfile ENH: Append CSS instead of overriding it ENH: Add watermark to drafts [DOC] Auto-generate changelog entry for PR bids-standard#381 Update src/06-extensions.md Retiring moderator duties for BEP021 [DOC] Auto-generate changelog entry for PR bids-standard#380 ...
* upstream/master: (439 commits) [DOC] Auto-generate changelog entry for PR bids-standard#394 Update 01-contributors.md [DOC] Auto-generate changelog entry for PR bids-standard#389 [DOC] Auto-generate changelog entry for PR bids-standard#386 moved list of extension proposals to the main BIDS website section 06-extensions remains, but now points to the main website Typo fix for typo fix Typo fix for typo fix [DOC] Auto-generate changelog entry for PR bids-standard#374 [FIX] Fix some typos and prose style issues [DOC] Auto-generate changelog entry for PR bids-standard#383 restructure according to @emdupre's proposal neurostars for everything not just technical Apply suggestions from code review MNT: Update Pipfile ENH: Append CSS instead of overriding it ENH: Add watermark to drafts [DOC] Auto-generate changelog entry for PR bids-standard#381 Update src/06-extensions.md Retiring moderator duties for BEP021 [DOC] Auto-generate changelog entry for PR bids-standard#380 ...
Addresses #373.
Created a mkdocs plugin that enables overriding config options on a per-branch basis: https://github.com/effigies/mkdocs-branchcustomization-plugin
Set the plugin to add a stylesheet to every branch but
master
. I pushed to the main repository and enabled RTD for this branch, so we can see it: https://bids-specification.readthedocs.io/en/enh-watermark/Things that need doing: