-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INFRA] add support for building PDF versions of the spec #431
[INFRA] add support for building PDF versions of the spec #431
Conversation
@sappelhoff done! #427 and #430 are redundant at this point and can be confusing. How do we deal with this? Apparently, deleting a PR isn't straightforward? |
I just closed the PRs, that should suffice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alright, thanks @Arshitha.
I did a final check and marked three small things. After that I am going to merge this.
src/04-modality-specific-files/04-intracranial-electroencephalography.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Arshitha for this big step!
PS: @Arshitha have you already added your contributions to our contributors list? You can just edit this wiki page and upon the next release, we'll add the information from the wiki to the repository: https://github.com/bids-standard/bids-specification/wiki/Contributors |
@sappelhoff Thank you for all the guidance! |
This is a PR almost identical to PR #400 updated-pdf-version-specs except that this has much cleaner commit history and was created to address the issue of unwanted commits in the above referenced PR.
To gain a better understanding of why certain decisions were made while fixing the issue of generating pdf version of the specs, discussions in the following issues would be useful references:
Bugs Fixed:
mkdocs.yml
)Enhancements required (non-exhaustive list):