-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Align tables in MRI section #465
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seems fixed to me in HTML: and also in PDF: screenshot of relevant pdf section: |
yarikoptic
approved these changes
May 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If renders fine now, lets proceed!? ;)
effigies
approved these changes
May 11, 2020
bids-maintenance
added a commit
that referenced
this pull request
May 11, 2020
yarikoptic
added a commit
to yarikoptic/bids-specification
that referenced
this pull request
May 19, 2020
* origin/master: (404 commits) [DOC] Auto-generate changelog entry for PR bids-standard#460 Apply suggestions from code review label -> index drop _part-, introduce _split- [DOC] Auto-generate changelog entry for PR bids-standard#459 [DOC] Auto-generate changelog entry for PR bids-standard#465 fix table Update src/99-appendices/06-meg-file-formats.md [DOC] Auto-generate changelog entry for PR bids-standard#441 inject _part into MEG spec update entity table FIX: clarify _part Apply suggestions from code review FIX: clarify participants tsv [DOC] Auto-generate changelog entry for PR bids-standard#457 Update Release_Protocol.md add pdf steps for release protocol FIX: remove BESA from list of restricted keywords Remove trailing space Add reference to PDF on front page of specification ... Conflicts: src/02-common-principles.md - had to meld with my previous wording etc.
satra
added a commit
to satra/bids-specification
that referenced
this pull request
May 23, 2020
* upstream/master: (113 commits) [DOC] Auto-generate changelog entry for PR bids-standard#152 [DOC] Auto-generate changelog entry for PR bids-standard#467 Specify that suffix must be alphanumeric ENH: make NOT RECOMMENDED stronger (SHOULD NOT) for zero padding for uniqueness ENH: Include leading . within definition of the file extension ENH: provide an example for a suffix based on an _eeg.vhdr filename [DOC] Auto-generate changelog entry for PR bids-standard#477 [DOC] Auto-generate changelog entry for PR bids-standard#460 Also ignore users urls on github Quote regexp in command line [INFRA] linkchecker - ignore github pull and tree URLs Apply suggestions from code review replace purview with scope label -> index Apply suggestions from code review drop _part-, introduce _split- Apply SA feedback and amended to purview [DOC] Auto-generate changelog entry for PR bids-standard#459 Add Domain Expert to Maintainers Group [DOC] Auto-generate changelog entry for PR bids-standard#465 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #464
good catch @yarikoptic 👍
we'll have to look at the PDF rendering as well, because in the PDF this "odd" (wrong) table formatting appears correct.