Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Maintainers - Scope responsibility #467

Merged
merged 4 commits into from
May 23, 2020

Conversation

franklin-feingold
Copy link
Collaborator

@franklin-feingold franklin-feingold commented May 11, 2020

This pull request is seeking to enhance our current definition of a Maintainer. Our current definition is derived from our governance document and implemented in our decision-making document.

We intend to add a Domain expert Purview (edit 5/12) Scope (edit 5/14) identification to a Maintainer. This Domain expert Purview (edit 5/12) Scope (edit 5/14) enhancement enables a Maintainer to specify what part of BIDS they intend to be responsible for maintaining. This addition will provide more clarity on how potential maintainers can specifically contribute to the Maintainers team by slowly taking on responsibilities in their domain of expertise. This will provide a clearer pathway into the Maintainers Group.

The purpose of this is to build more resilience and sustainability into our community by reducing the barrier to entry through identifying more specific (and diverse) contribution opportunities

DECISION-MAKING.md Outdated Show resolved Hide resolved
@franklin-feingold franklin-feingold changed the title [MISC] Maintainers - Domain expert responsibility [MISC] Maintainers - Purview responsibility May 12, 2020
@franklin-feingold
Copy link
Collaborator Author

franklin-feingold commented May 12, 2020

Amended this PR to replace Domain expert with Purview

Linkchecker is failing due to bad gateways from https://www.wikiwand.com/ . It is affecting all of our links to units in our unit appendix (V). I was able to navigate and render the pages

Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current prose feels a bit weird, as if the word is being made up and doesn't already have a meaning. Tried to rewrite it a bit more naturally. We can also use "scope" if that's less awkward.

It also reads as if only one can be declared, which seems artificially limiting. Updated to allow multiple.

DECISION-MAKING.md Outdated Show resolved Hide resolved
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
@franklin-feingold
Copy link
Collaborator Author

sounds good to me

+1 for purview, I think purview is less constraining than scope

sappelhoff
sappelhoff previously approved these changes May 13, 2020
Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reads nicely now and I also like "purview" ... perhaps because the German translation is "Zuständigkeitsbereich" and that's a very German thing to say 🙈

@hoechenberger
Copy link
Collaborator

hoechenberger commented May 13, 2020

@sappelhoff

Reads nicely now and I also like "purview" ... perhaps because the German translation is "Zuständigkeitsbereich" and that's a very German thing to say 🙈

This one got me too… never encountered this word before and the translation just seemed a little odd. Still – wondering if using such a word is a good idea in terms of accessibility? Shouldn't we try stick to ~Simple English in general? But maybe that's a different discussion :)

@franklin-feingold
Copy link
Collaborator Author

I agree that would be ideal but likely very subjective depending on who is reviewing. Having guidance on global accessibility would be good (AFAIK there isn't)

Perhaps may you have a suggestion for this case?

@effigies
Copy link
Collaborator

"scope" covers most of the meaning. If that's simpler for non-English speakers, I'm fine with that.

@hoechenberger
Copy link
Collaborator

I actually just got in touch with a close friend of mine who is a native English speaker, a British and American citizen, and has lived in both countries for a considerable amount of time (And she's even a professional non-academic writer, haha). Well – turns out she had to look up that word in a dictionary too. Now ok this is N=1, but I'm getting the strong feeling we should actually not use purview, and pick scope instead :) my 2ct!

@sappelhoff
Copy link
Member

I am fine with scope as well, I think it's better than what we had before (specialty, and domain-expert), and it's a valid argument to use words that 80% of the people will only have to look up 20% of the time 😉

@hoechenberger
Copy link
Collaborator

@sappelhoff Yes let's Pareto-optimize our writing here 🤣

@franklin-feingold
Copy link
Collaborator Author

franklin-feingold commented May 14, 2020

sounds good - applied change to scope

now the link checker is 429'ing (too many requests) to GitHub - the links are active

@franklin-feingold franklin-feingold changed the title [MISC] Maintainers - Purview responsibility [MISC] Maintainers - Scope responsibility May 14, 2020
@sappelhoff sappelhoff merged commit 907cae0 into bids-standard:master May 23, 2020
@sappelhoff
Copy link
Member

Thanks @franklin-feingold

satra added a commit to satra/bids-specification that referenced this pull request May 23, 2020
* upstream/master: (113 commits)
  [DOC] Auto-generate changelog entry for PR bids-standard#152
  [DOC] Auto-generate changelog entry for PR bids-standard#467
  Specify that suffix must be alphanumeric
  ENH: make NOT RECOMMENDED stronger (SHOULD NOT) for zero padding for uniqueness
  ENH: Include leading . within definition of the file extension
  ENH: provide an example for a suffix based on an _eeg.vhdr filename
  [DOC] Auto-generate changelog entry for PR bids-standard#477
  [DOC] Auto-generate changelog entry for PR bids-standard#460
  Also ignore users urls on github
  Quote regexp in command line
  [INFRA] linkchecker - ignore github pull and tree URLs
  Apply suggestions from code review
  replace purview with scope
  label -> index
  Apply suggestions from code review
  drop _part-, introduce _split-
  Apply SA feedback and amended to purview
  [DOC] Auto-generate changelog entry for PR bids-standard#459
  Add Domain Expert to Maintainers Group
  [DOC] Auto-generate changelog entry for PR bids-standard#465
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants