Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Reorganize rec, ce entities, _defacemask #550

Merged
merged 2 commits into from
Aug 8, 2020

Conversation

emdupre
Copy link
Collaborator

@emdupre emdupre commented Jul 31, 2020

Closes #547.

Reorganizes the MRI modality-specific description such that there is a clear distinction between the rec- and ce- entities, and that the _defacemask suffix is not included as an entity.

@emdupre emdupre requested a review from chrisgorgo as a code owner July 31, 2020 01:58
Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some suggestions for cleanup, while we're here.

Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks more sensible to me than before, thanks @emdupre!

@sappelhoff
Copy link
Member

merging now, because everybody agreed or had no objections. thanks a bunch!

@sappelhoff sappelhoff merged commit 2636399 into bids-standard:master Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing heading for _defacemask ?
3 participants