-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] harmonize and thus shorten templates etc #93
Merged
Merged
Changes from 8 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
375c040
RF: use lowercase optional instead of OPTIONAL
yarikoptic 1c4b19a
[DATALAD RUNCMD] No need for session_ prefix in ses-<session_label> -…
yarikoptic 611a1a8
[DATALAD RUNCMD] No need for participant_ prefix in sub-<participant_…
yarikoptic e5538b9
[DATALAD RUNCMD] No need for task_ prefix in task-<task_label> -- imp…
yarikoptic 6b32ef1
[DATALAD RUNCMD] No need for run_ prefix in run-<run_index> -- implied
yarikoptic 568bf6d
[DATALAD RUNCMD] No need for dir_ prefix in dir-<dir_label> -- implied
yarikoptic 4d42623
ENH: adjusting the text since there is no longer dir_label
yarikoptic 4f71449
Merge remote-tracking branch 'origin/master' into rf-harmonize
yarikoptic 50f1735
Revert "RF: use lowercase optional instead of OPTIONAL"
yarikoptic d4de435
Consistent use of OPTIONAL (not optional or (optional)) keyword in MR…
yarikoptic c961824
Consistent use of OPTIONAL and REQUIRED (instead of lower etc case) i…
yarikoptic d5c628d
One more OPTIONAL instead of (optional)
yarikoptic 9221149
BF: fixed table formatting
yarikoptic 0aa1ab3
Merge remote-tracking branch 'origin/master' into rf-harmonize
yarikoptic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason why lowercase
OPTIONAL
? It's supposed to be an indication that this is a RFC2119 label. If you are proposing to change that it should be done in another PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ha, also found https://tools.ietf.org/html/rfc8174 ;-) so indeed then should be all UPPERCASE to be keywords.
Again -- I was just aiming for consistency and there were uses both ways, I will just push (later today) a fix to get them all UPPERCASED