Fix comment parsing speed regression #2701
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kisslorand
force-pushed
the
Fix-speed-regression
branch
2 times, most recently
from
af14ab1 to
b1faf80
Compare
kisslorand
force-pushed
the
Fix-speed-regression
branch
from
b1faf80 to
e032615
Compare
kisslorand
force-pushed
the
Fix-speed-regression
branch
3 times, most recently
from
79a013f to
bfd64b0
Compare
kisslorand
force-pushed
the
Fix-speed-regression
branch
from
bfd64b0 to
f16a412
Compare
kisslorand
force-pushed
the
Fix-speed-regression
branch
from
f16a412 to
806853d
Compare
kisslorand
force-pushed
the
Fix-speed-regression
branch
from
7f0fcff to
b93491d
Compare
kisslorand
force-pushed
the
Fix-speed-regression
branch
from
b93491d to
d15f717
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Bump |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
kisslorand
force-pushed
the
Fix-speed-regression
branch
from
d15f717 to
f54bd85
Compare
kisslorand
force-pushed
the
Fix-speed-regression
branch
11 times, most recently
from
ee6c6e0 to
009adc0
Compare
kisslorand
force-pushed
the
Fix-speed-regression
branch
from
009adc0 to
7f3189c
Compare
kisslorand
force-pushed
the
Fix-speed-regression
branch
from
7f3189c to
7629777
Compare
|
This PR has been automatically marked as stale because it has had no activity for the last 60 days. It will be closed in 7 days if no further activity occurs. Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
BTT or MKS TFT
Description
PR #2671 promised to "Optimize comment parsing in comment.c", instead it crowded the MCU with unnecessary instructions, all these during printing, where speed is crucial. The opposite of optimize was done, there is no benefit from it, only loss. The resulting code is not even smaller with one single byte.
Because of PR #2671 the first word in every comment from the G-code file is preprocessed even if it is not even a candidate for a known keyword. This takes time and it is unnecessary, not to mention again that this is during printing.
This PR brings back the systematic approach that was done before this "optimization" and also does what PR #2671 assumably wanted to do, reduces the footprint of "comment.c" on the FW's size.
An alternative for `strlwr()' and 'strupr()' is introduced. The introduced functions are lighter and are returning the pointer to the processed string.
Benefits
Related Issues