Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: 🎨 migrated component to TSX (#48) #10116

Merged
merged 80 commits into from
Dec 28, 2023
Merged

refactor: 🎨 migrated component to TSX (#48) #10116

merged 80 commits into from
Dec 28, 2023

Conversation

likhith-deriv
Copy link
Contributor

@likhith-deriv likhith-deriv commented Sep 16, 2023 •
edited
Loading

  • refactor: 🎨 migrated component to TSX
  • refactor: ⚰️ unused import
  • refactor: 🔬 simplified logic

@likhith-deriv
refactor: 🎨 migrated component to TSX (#48)
2703f09 
* refactor: 🎨 migrated component to TSX

* refactor: ⚰️ unused import
@vercel
Copy link

vercel bot commented Sep 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 28, 2023 8:04am

@likhith-deriv likhith-deriv marked this pull request as ready for review September 16, 2023 15:52
@github-actions
Copy link
Contributor

github-actions bot commented Sep 16, 2023 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/10116](https://github.com/binary-com/deriv-app/pull/10116)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-likhith-deriv-sprint-10-account-packa-17c1fb.binary.sx?qa_server=red.derivws.com&app_id=23926
    - **Original**: https://deriv-app-git-fork-likhith-deriv-sprint-10-account-packa-17c1fb.binary.sx
- **App ID**: `23926`

@github-actions
Copy link
Contributor

github-actions bot commented Sep 16, 2023 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 88
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-likhith-deriv-sprint-10-account-packa-17c1fb.binary.sx/

@coveralls
Copy link

coveralls commented Sep 16, 2023 •
edited
Loading

Coverage Status

coverage: 33.999% (+0.009%) from 33.99%
when pulling 49c04c9 on likhith-deriv:sprint-10/account-package-refactor
into c08f631 on binary-com:master.

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 28, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

9 New issues
0 Security Hotspots
No data about Coverage
3.9% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@likhith-deriv likhith-deriv merged commit 7bc8fdc into binary-com:master Dec 28, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amina-deriv amina-deriv amina-deriv approved these changes

@yauheni-deriv yauheni-deriv yauheni-deriv approved these changes

@shaheer-deriv shaheer-deriv shaheer-deriv approved these changes

@shahzaib-deriv shahzaib-deriv shahzaib-deriv approved these changes

@maryia-deriv maryia-deriv Awaiting requested review from maryia-deriv maryia-deriv is a code owner

@ali-hosseini-deriv ali-hosseini-deriv Awaiting requested review from ali-hosseini-deriv ali-hosseini-deriv is a code owner

@balakrishna-deriv balakrishna-deriv Awaiting requested review from balakrishna-deriv

@yashim-deriv yashim-deriv Awaiting requested review from yashim-deriv

@adrienne-deriv adrienne-deriv Awaiting requested review from adrienne-deriv

@thisyahlen-deriv thisyahlen-deriv Awaiting requested review from thisyahlen-deriv

@farhan-nurzi-deriv farhan-nurzi-deriv Awaiting requested review from farhan-nurzi-deriv

@wojciech-deriv wojciech-deriv Awaiting requested review from wojciech-deriv

@mahdiyeh-deriv mahdiyeh-deriv Awaiting requested review from mahdiyeh-deriv

@farrah-deriv farrah-deriv Awaiting requested review from farrah-deriv

@nijil-deriv nijil-deriv Awaiting requested review from nijil-deriv

@hirad-deriv hirad-deriv Awaiting requested review from hirad-deriv

@prince-deriv prince-deriv Awaiting requested review from prince-deriv

@sandeep-deriv sandeep-deriv Awaiting requested review from sandeep-deriv

@vinu-deriv vinu-deriv Awaiting requested review from vinu-deriv

@suisin-deriv suisin-deriv Awaiting requested review from suisin-deriv

@matin-deriv matin-deriv Awaiting requested review from matin-deriv matin-deriv is a code owner

Assignees
No one assigned
Labels
Account Components Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@likhith-deriv @coveralls @matin-deriv @amina-deriv @suisin-deriv @yauheni-deriv @shaheer-deriv @shahzaib-deriv