refactor: 🎨 migrated component to TSX #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 6205409962
💛 - Coveralls |
|
⏳ Generating Lighthouse report... |
likhith-deriv
merged commit 2703f09
into
sprint-10/account-package-refactor
2 of 3 checks passed
yauheni-deriv
added a commit
that referenced
this pull request
Dec 28, 2023
* refactor: 🎨 migrated component to TSX (#48) * refactor: 🎨 migrated component to TSX * refactor: ⚰️ unused import * fix: 🎨 migrated config to tsx (#49) * refactor: migrated components to tsx * refactor: migrated components to tsx * chore: added testcases * chore: added testcases * Merge branch 'master' into sprint-10/account-package-refactor * fix: 🧪 fixed failing testcase * fix: 🧪 fixed failing testcase * Likhith/migrate poo form (#50) * refactor: removed dead code * chore: fixed error condition * chore: update from master * fix: error object props * chore: poo ts init (#53) * chore: poo ts init * chore: remove query * chore: some types fix * chore: revert observer for poo form --------- Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * feat: refactored POO form values * fix: Error text for Failure of IDV * fix: file upload * fix: POO validation * fix: failing testcase * fix: added validations * fix: types of payment method * fix: testcases for POO * fix: code smells * fix: resolved code smells * refactor: types errors (#58) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * fix: resolved code smells * fix: code smells * fix: async behavior * fix: import constant * fix: rename Const * refactor: sonarcloud issues * fix: incorporated review comments * fix: Convert the conditional to a boolean to avoid leaked value * fix: incorporated review comments * refactor: incorporated review comments * fix: removed duplicate status * chore: poo-form review comments * fix: code smells * fix: failing testcase * fix: wrong upload settings field name * chore: unused import remove * fix: duplicate filling of payment-method * fix: removed unused import * fix:reset form * fix: resolved error display bugs * Merge branch 'master' into sprint-10/account-package-refactor * fix: issue related with POO disble * fix: code smells * fix: code smells * refactor: incorporated review comments * fix: removed prop drilling * fix: incorporated useFileUploader hook * refactor: removed hook implementation * fix: resolved loading and validation * fix: incorrect status display issue * chore: removed console statements * fix: reinitialize form on value change --------- Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com>
likhith-deriv
pushed a commit
that referenced
this pull request
Feb 19, 2024
…2443) * feat: create play stop controller * refactor: improve volume controller * fix: ui and volume bugs * refactor: functions helpers * refactor: remove extra animation * refactor: apply first part of suggestions * refactor: upgrade dropdown component * refactor: remove inline style * refactor: add more ref * refactor: add flag for animation instead of inline style * refactor: add extra ref and remove inline style for volume control * fix: revert browser check * feat: add scroll functionality * refactor: recalculate scroll heigh * chore: fix typo * chore: apply suggestions * refactor: make srcrollbar visible for player * refactor: add tests for overlay, volume and playback rate files * refactor: add tests for video control file and apply suggestion * refactor: style nesting * refactor: remove sonarcloud smell * refactor: get rid of extra ref usage * refactor: add tests for browser detect function * refactor: add tests for formatduration function * refactor: typos * Maryia/test: VideoPlayer + optimization (#48) * test: VideoPlayer * refactor: type TMockedStreamProps * test: VideoPlayer * chore: optimization & improvements * test: add test for video player (replay feature) * refactor: rename refs * chore: voluma and animation fixes * chore: volume control functions refactor * refactor: change rounding * fix: autoplaying after switching tabs * refactor: improve animation * fix: gap berween drag dot and progress bar * refactor: reworked animationframe * refactor: remove use effect * refactor: improve perfomance * fix: Safari issues for long living tabs * refactor: ad debounce and cleaning * refactor: ad debounce and cleaning * refactor: fix tests * fix: mobile control pannel * fix: first launch time issue * refactor: change type of th check for rewind * refactor: apply suggestions --------- Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Migrated SampleCreditCardModal to TSX