Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove bot bundle chunk from landing page #10403

Merged
merged 1 commit into from
Oct 11, 2023
Merged

fix: remove bot bundle chunk from landing page #10403

merged 1 commit into from
Oct 11, 2023

Conversation

shafin-deriv
Copy link
Contributor

Changes:

Bot bundle is loading on the homepage.

  • changed the webpackChunkName from bot to bot-web-ui-app

@boring-cyborg boring-cyborg bot added the Core label Oct 2, 2023
@vercel
Copy link

vercel bot commented Oct 2, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 2, 2023 3:42am

@sonarcloud
Copy link

sonarcloud bot commented Oct 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.8% 0.8% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/10403](https://github.com/binary-com/deriv-app/pull/10403)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-shafin-deriv-shafin-bot-744fix-bot-ch-ea978b.binary.sx?qa_server=red.binaryws.com&app_id=24197
    - **Original**: https://deriv-app-git-fork-shafin-deriv-shafin-bot-744fix-bot-ch-ea978b.binary.sx
- **App ID**: `24197`

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 20
🟧 Accessibility 75
🟧 Best practices 83
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-shafin-deriv-shafin-bot-744fix-bot-ch-ea978b.binary.sx/

@vinu-deriv vinu-deriv merged commit c117ea2 into binary-com:master Oct 11, 2023
6 checks passed
sandeep-deriv added a commit that referenced this pull request Oct 12, 2023
@sandeep-deriv
Revert "fix: remove bot bundle chunk from landing page (#10403)"
d58e289 
This reverts commit c117ea2.
@sandeep-deriv sandeep-deriv mentioned this pull request Oct 12, 2023
Merged
sandeep-deriv added a commit that referenced this pull request Oct 12, 2023
@sandeep-deriv
Revert "fix: remove bot bundle chunk from landing page (#10403)" (#10624
b568ccd 
)

This reverts commit c117ea2.
ali-hosseini-deriv added a commit that referenced this pull request Oct 12, 2023
@ali-hosseini-deriv
Revert "Revert "fix: remove bot bundle chunk from landing page (#10403)…
076ac6d 
…" (#10624)"

This reverts commit b568ccd.
ali-hosseini-deriv added a commit that referenced this pull request Oct 12, 2023
@ali-hosseini-deriv
Revert "Revert "fix: remove bot bundle chunk from landing page (#10403)…
84683b3 
…" (#10624)" (#10629)

This reverts commit b568ccd.
@vinu-deriv vinu-deriv mentioned this pull request Oct 13, 2023
Merged
vinu-deriv added a commit that referenced this pull request Oct 13, 2023
@vinu-deriv @sandeep-deriv
Revert "fix: remove bot bundle chunk from landing page (#10403)" (#10663
c47bf30 
)

This reverts commit c117ea2.

Co-authored-by: Sandeep Rajput <90243468+sandeep-deriv@users.noreply.github.com>
vinu-deriv pushed a commit that referenced this pull request Oct 17, 2023
@shafin-deriv @vinu-deriv
fix: remove bot bundle chunk from landing page (#10403)
0463fd8
vinu-deriv pushed a commit that referenced this pull request Oct 17, 2023
@sandeep-deriv @vinu-deriv
Revert "fix: remove bot bundle chunk from landing page (#10403)" (#10624
e90c92b 
)

This reverts commit c117ea2.
vinu-deriv pushed a commit that referenced this pull request Oct 17, 2023
@ali-hosseini-deriv @vinu-deriv
Revert "Revert "fix: remove bot bundle chunk from landing page (#10403)…
03f1361 
…" (#10624)" (#10629)

This reverts commit b568ccd.
vinu-deriv added a commit that referenced this pull request Oct 17, 2023
@vinu-deriv @sandeep-deriv
Revert "fix: remove bot bundle chunk from landing page (#10403)" (#10663
8252211 
)

This reverts commit c117ea2.

Co-authored-by: Sandeep Rajput <90243468+sandeep-deriv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balakrishna-deriv balakrishna-deriv balakrishna-deriv approved these changes

@sandeep-deriv sandeep-deriv sandeep-deriv approved these changes

@ali-hosseini-deriv ali-hosseini-deriv Awaiting requested review from ali-hosseini-deriv ali-hosseini-deriv is a code owner

@matin-deriv matin-deriv Awaiting requested review from matin-deriv matin-deriv is a code owner

@maryia-deriv maryia-deriv Awaiting requested review from maryia-deriv maryia-deriv is a code owner

Assignees
No one assigned
Labels
Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shafin-deriv @balakrishna-deriv @sandeep-deriv @vinu-deriv