Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: remove bot bundle chunk from landing page" #10624

Merged

Conversation

sandeep-deriv
Copy link
Contributor

Reverts #10403

@vercel
Copy link

vercel bot commented Oct 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 12, 2023 10:38am

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/10624](https://github.com/binary-com/deriv-app/pull/10624)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-revert-10403-shafin-bot-744fix-bot-chunk-issue.binary.sx?qa_server=red.binaryws.com&app_id=23847
    - **Original**: https://deriv-app-git-revert-10403-shafin-bot-744fix-bot-chunk-issue.binary.sx
- **App ID**: `23847`

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-revert-10403-shafin-bot-744fix-bot-chunk-issue.binary.sx/

@sandeep-deriv sandeep-deriv merged commit b568ccd into master Oct 12, 2023
4 of 6 checks passed
@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

ali-hosseini-deriv added a commit that referenced this pull request Oct 12, 2023
vinu-deriv pushed a commit that referenced this pull request Oct 17, 2023
vinu-deriv pushed a commit that referenced this pull request Oct 17, 2023
@ali-hosseini-deriv ali-hosseini-deriv deleted the revert-10403-shafin/BOT-744/fix--bot-chunk-issue branch August 16, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants