Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dtra]/Ahmad/showing digits on the Matchers/Differs contract type on mobile screen #12010

Merged

Conversation

ahmadtaimoor-deriv
Copy link
Contributor

@ahmadtaimoor-deriv ahmadtaimoor-deriv commented Dec 5, 2023

Changes:

It was a bug where the digits were not visible on the mobile screen for the matchers/differs contract type.

Screenshots:

Copy link

vercel bot commented Dec 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 5, 2023 5:16am

Copy link

sonarcloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

github-actions bot commented Dec 5, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12010](https://github.com/binary-com/deriv-app/pull/12010)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-ahmadtaimoor-deriv-fixdigitsonmobile.binary.sx?qa_server=red.derivws.com&app_id=38677
    - **Original**: https://deriv-app-git-fork-ahmadtaimoor-deriv-fixdigitsonmobile.binary.sx
- **App ID**: `38677`

Copy link
Contributor

github-actions bot commented Dec 5, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 85
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-ahmadtaimoor-deriv-fixdigitsonmobile.binary.sx/

@coveralls
Copy link

coveralls commented Dec 5, 2023

Coverage Status

coverage: 29.708% (+0.003%) from 29.705%
when pulling 5a38bd6 on ahmadtaimoor-deriv:fix_digits_on_mobile
into 9bec43c on binary-com:master.

@ahmadtaimoor-deriv ahmadtaimoor-deriv changed the title [dtra]/Ahmad/showing Digits on the Matchers/Differs contract type [dtra]/Ahmad/showing digits on the Matchers/Differs contract type on mobile screen Dec 5, 2023
Copy link
Contributor

github-actions bot commented Dec 5, 2023

Generating Lighthouse report...

Copy link
Contributor

github-actions bot commented Dec 5, 2023

❌ Smoke test run (1) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Dec 5, 2023

❌ Smoke test run (2) failed. See logs for details: Visit Action

@heorhi-deriv heorhi-deriv merged commit 7bc29f4 into binary-com:master Dec 5, 2023
9 checks passed
heorhi-deriv pushed a commit that referenced this pull request Dec 5, 2023
hamza-deriv added a commit that referenced this pull request Dec 6, 2023
hamza-deriv added a commit that referenced this pull request Dec 6, 2023
hamza-deriv added a commit that referenced this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants