Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TRAH] Thisyahlen/traders hub package #12208

Merged
merged 11 commits into from
Dec 15, 2023
Merged

[TRAH] Thisyahlen/traders hub package #12208

merged 11 commits into from
Dec 15, 2023

Conversation

thisyahlen-deriv
Copy link
Contributor

@thisyahlen-deriv thisyahlen-deriv commented Dec 13, 2023 •
edited
Loading

Changes:

  1. Add a new package called tradershub
  2. A revamp on legacy code

Screenshots:

Screenshot 2023-12-14 at 9 59 30 AM

@vercel Vercel
Copy link

vercel bot commented Dec 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 15, 2023 1:22am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2023 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/12208](https://github.com/binary-com/deriv-app/pull/12208)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-tradershu-746be8.binary.sx?qa_server=red.derivws.com&app_id=23839
    - **Original**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-tradershu-746be8.binary.sx
- **App ID**: `23839`

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2023 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 76
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-tradershu-746be8.binary.sx/

@thisyahlen-deriv thisyahlen-deriv self-assigned this Dec 13, 2023
@thisyahlen-deriv thisyahlen-deriv changed the title Thisyahlen/traders hub package [TRAH] Thisyahlen/traders hub package Dec 13, 2023
@thisyahlen-deriv thisyahlen-deriv marked this pull request as ready for review December 13, 2023 09:52
adrienne-deriv
adrienne-deriv previously approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@adrienne-deriv adrienne-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yashim-deriv
yashim-deriv previously approved these changes Dec 14, 2023
View reviewed changes
@aizad-deriv aizad-deriv mentioned this pull request Dec 14, 2023
Closed
mahdiyeh-deriv
mahdiyeh-deriv previously approved these changes Dec 14, 2023
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 15, 2023

Quality Gate Failed Quality Gate failed

Failed conditions

C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@coveralls
Copy link

Coverage Status

coverage: 31.618% (-0.006%) from 31.624%
when pulling 6281c77 on thisyahlen-deriv:thisyahlen/traders_hub_package
into 8e2d10d on binary-com:master.

@mahdiyeh-deriv mahdiyeh-deriv merged commit 586b9bb into binary-com:master Dec 15, 2023
5 of 6 checks passed
@aizad-deriv aizad-deriv mentioned this pull request Dec 15, 2023
Closed
maryia-deriv added a commit to maryia-deriv/deriv-app that referenced this pull request Dec 15, 2023
@maryia-deriv
Revert "[TRAH] Thisyahlen/traders hub package (binary-com#12208)"
d72a7d8 
This reverts commit 586b9bb.
@maryia-deriv maryia-deriv mentioned this pull request Dec 15, 2023
Closed
maryia-deriv added a commit to maryia-deriv/deriv-app that referenced this pull request Dec 15, 2023
@maryia-deriv
Revert "[TRAH] Thisyahlen/traders hub package (binary-com#12208)"
99b2ac1 
This reverts commit 586b9bb.
@maryia-deriv maryia-deriv mentioned this pull request Dec 15, 2023
Closed
@aizad-deriv aizad-deriv mentioned this pull request Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yashim-deriv yashim-deriv yashim-deriv left review comments

@mahdiyeh-deriv mahdiyeh-deriv mahdiyeh-deriv left review comments

@adrienne-deriv adrienne-deriv adrienne-deriv left review comments

@ali-hosseini-deriv ali-hosseini-deriv Awaiting requested review from ali-hosseini-deriv ali-hosseini-deriv is a code owner

@matin-deriv matin-deriv Awaiting requested review from matin-deriv matin-deriv is a code owner

@maryia-deriv maryia-deriv Awaiting requested review from maryia-deriv maryia-deriv is a code owner

@nijil-deriv nijil-deriv Awaiting requested review from nijil-deriv

@balakrishna-deriv balakrishna-deriv Awaiting requested review from balakrishna-deriv balakrishna-deriv is a code owner

Assignees

@thisyahlen-deriv thisyahlen-deriv

Labels
AppStore Core Shared Trader's Hub PR's that are created to the new trader's hub package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thisyahlen-deriv @coveralls @yashim-deriv @mahdiyeh-deriv @adrienne-deriv