Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TRAH/WIP] Aizad/traders hub package pt.2 #12253

Closed
wants to merge 15 commits into from
Closed

[TRAH/WIP] Aizad/traders hub package pt.2 #12253

wants to merge 15 commits into from

Conversation

aizad-deriv
Copy link
Contributor

@aizad-deriv aizad-deriv commented Dec 14, 2023 •
edited
Loading

This PR is a continuation from this branch to make tradershub its own independent package.

Changes:

  • updated changes from mentioned branch above
  • change file extension
  • removed tailwind from core and only install it inside of tradershub package
  • added Traders Hub homepage skeleton for display purposes only

Screenshots:

Screenshot 2023-12-14 at 12 31 47 PM

@vercel Vercel
Copy link

vercel bot commented Dec 14, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 15, 2023 6:40am

@aizad-deriv aizad-deriv changed the title Aizad/traders hub package [TRAH/WIP] Aizad/traders hub package Dec 14, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 14, 2023 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/12253](https://github.com/binary-com/deriv-app/pull/12253)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-aizad-deriv-aizad-traders-hub-package.binary.sx?qa_server=red.derivws.com&app_id=23813
    - **Original**: https://deriv-app-git-fork-aizad-deriv-aizad-traders-hub-package.binary.sx
- **App ID**: `23813`

@coveralls
Copy link

coveralls commented Dec 14, 2023 •
edited
Loading

Coverage Status

coverage: 31.616% (-0.002%) from 31.618%
when pulling 62bab3d on aizad-deriv:aizad/traders-hub-package
into f3020d6 on binary-com:master.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 14, 2023 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 76
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-aizad-deriv-aizad-traders-hub-package.binary.sx/

@thisyahlen-deriv thisyahlen-deriv added the Trader's Hub PR's that are created to the new trader's hub package label Dec 14, 2023
@aizad-deriv aizad-deriv changed the title [TRAH/WIP] Aizad/traders hub package [TRAH/WIP] Aizad/traders hub package pt.2 Dec 14, 2023
@aizad-deriv
chore: remove tailwind from core
97d0315 
- remove autoprefixer, tailwindcss & quill-components from core
- edit postcss config in core
- remove tailwind config in core and moved content to config inside of tradershub
@aizad-deriv
chore: updated styles
175eeff 
- remove scss styles
- remove index.js for scss inside of webpack
- added traders hub mainpage template
@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 15, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
2.5% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@aizad-deriv aizad-deriv deleted the aizad/traders-hub-package branch December 18, 2023 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ali-hosseini-deriv ali-hosseini-deriv Awaiting requested review from ali-hosseini-deriv ali-hosseini-deriv is a code owner

@matin-deriv matin-deriv Awaiting requested review from matin-deriv matin-deriv is a code owner

@maryia-deriv maryia-deriv Awaiting requested review from maryia-deriv maryia-deriv is a code owner

@mahdiyeh-deriv mahdiyeh-deriv Awaiting requested review from mahdiyeh-deriv

@nijil-deriv nijil-deriv Awaiting requested review from nijil-deriv

@balakrishna-deriv balakrishna-deriv Awaiting requested review from balakrishna-deriv balakrishna-deriv is a code owner

@yashim-deriv yashim-deriv Awaiting requested review from yashim-deriv yashim-deriv is a code owner

Assignees
No one assigned
Labels
AppStore Core Shared Trader's Hub PR's that are created to the new trader's hub package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aizad-deriv @coveralls @thisyahlen-deriv