Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "thisyahlen/TRAH-2997/chore: fix terms and conditions link to deriv com when user changes language" #13890

Conversation

hirad-deriv
Copy link
Contributor

Reverts #13878

Copy link

@review-deriv review-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description is too short. You can use this format:

# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.

# Cards
* https://clickup.com/12345
* https://clickup.com/12346

Copy link

vercel bot commented Feb 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Feb 29, 2024 4:53am

Copy link

sonarcloud bot commented Feb 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13890](https://github.com/binary-com/deriv-app/pull/13890)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-revert-13878-thisyahlen-trah-2997termsandc-7b68ab.binary.sx?qa_server=red.derivws.com&app_id=23852
    - **Original**: https://deriv-app-git-revert-13878-thisyahlen-trah-2997termsandc-7b68ab.binary.sx
- **App ID**: `23852`

Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-revert-13878-thisyahlen-trah-2997termsandc-7b68ab.binary.sx/

@hirad-deriv hirad-deriv merged commit e2201e3 into master Feb 29, 2024
5 of 8 checks passed
@ali-hosseini-deriv ali-hosseini-deriv deleted the revert-13878-thisyahlen/TRAH-2997/terms_and_conditions_link_404_error branch August 16, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants