Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DTRA]/Ahmad/Update Dtrader Url #14558

Merged

Conversation

ahmadtaimoor-deriv
Copy link
Contributor

@ahmadtaimoor-deriv ahmadtaimoor-deriv commented Apr 9, 2024

Changes:

The PR updates the url of dtrader . It will no more be the default page and we can reach it only via /dtrader.

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Apr 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview May 28, 2024 3:44am

Copy link
Contributor

github-actions bot commented Apr 9, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/14558](https://github.com/binary-com/deriv-app/pull/14558)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-ahmadtaimoor-deriv-fupdatedtraderurl.binary.sx?qa_server=red.derivws.com&app_id=38743
    - **Original**: https://deriv-app-git-fork-ahmadtaimoor-deriv-fupdatedtraderurl.binary.sx
- **App ID**: `38743`

Copy link
Contributor

github-actions bot commented Apr 9, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 32
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-ahmadtaimoor-deriv-fupdatedtraderurl.binary.sx/

@ahmadtaimoor-deriv ahmadtaimoor-deriv marked this pull request as ready for review April 15, 2024 07:42
maryia-deriv
maryia-deriv previously approved these changes Apr 24, 2024
maryia-deriv
maryia-deriv previously approved these changes Apr 24, 2024
akmal-deriv
akmal-deriv previously approved these changes Apr 25, 2024
Copy link

sonarcloud bot commented May 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

Generating Lighthouse report...

@balakrishna-deriv balakrishna-deriv merged commit 2f4292d into binary-com:master May 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants