[TRAH] Sergei / TRAH 3229 / Making Traders Hub the landing page and introducing Traders Hub's logged out version #14740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th-logout-version
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-sergei-deriv-sergei-trah-3229th-logou-4eb5a4.binary.sx/ |
…th-logout-version
…i-deriv/deriv-app into nijil/wall-3711/wallets-route-update
…-update Nijil/wall 3711/wallets route update
…th-logout-version
sergei-deriv
force-pushed
the
sergei/trah-3229/th-logout-version
branch
from
06f7551
to
f75ba34
Compare
|
|
⏳ Generating Lighthouse report... |
habib-deriv
approved these changes
May 27, 2024
vinu-deriv
pushed a commit
to vinu-deriv/deriv-app
that referenced
this pull request
May 28, 2024
…ntroducing Traders Hub's logged out version (binary-com#14740) * chore: initial setup * chore: test case fix * chore: fixing test cases * chore: fixing test cases * chore: binary link fix * chore: add root route / * feat: started * feat: intermediate result * feat: intermediate result 2 * feat: add 1st test case * chore: review fix * chore: fixing test case * chore: redirecting trading button to dtrader * fix: test case * fix: trigger * feat: change hardcoded dtrader route to routes.trade * feat: add trustpilot widget * refactor: extract the code to separate components * feat: add getLandingCompany to client store * feat: create trustpilot helper function * feat: add some icons for banner and trustpilot * feat: intermediate result * feat: complete widget and banner * feat: refactor the code a little bit * feat: complete with options and multipliers * feat: change trustpilot data type * feat: changed content for CFDs part * feat: renamed some components * feat: change 3 headers * fix: add mock for header tests * feat: complete changes for header * feat: change trust pilot widget data * feat: separate styles * feat: add some styles * fix: remove exclamation mark * feat: make legacy TH route as root * fix: implement sonalcloud suggestions * fix: repair tests * feat: get back changes for content because it will be done by card trah-3251 * feat: create separate components for option and cfds titles and description * feat: remove waiting for landing company and show just eu and non-eu versions * feat: change routes to legacy th * feat: change routes to legacy th 2 * fix: repair tests due to route changes * feat: add exact to the trades_hub route * feat: add position absolute to the image * feat: add redirection from old traders hub route to the new one * fix: same route for wallets and TH * fix: change route order to fix old TH route redirect * feat: add redirection to dtrader * fix: wallet_transfer route in shared * chore: code clean-up * chore: more code clean-up * fix: move wallets check out of appstore Co-authored-by: Aum <aum@deriv.com> * chore: reset file to base branch * fix: compare account route height and hover shadow clipping * chore: remove unused import * fix: repair wallet tests * fix: add logged_in_app_platform and logged_out_app_platform * feat: show content for incognito * chore: refactor routes.ts for better readability * fix: insufficient balance modal button routing * fix: routing to contract page giving 404 * feat: change options & multipliers to options * feat: update mobile header --------- Co-authored-by: ahmadtaimoor-deriv <129935294+ahmadtaimoor-deriv@users.noreply.github.com> Co-authored-by: nijil-deriv <nijil@deriv.com> Co-authored-by: Aum <aum@deriv.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
NOTE: Extends this PR because broken tests due to routes changes were fixed there.
Screenshots:
[Desktop EU]
[Desktop Non-EU]
[Responsive EU]
[Responsive Non-EU]
