[FEQ-2166]/Tablet view - Reports, Dtrader, Tradershub #15011

habib-deriv · 2024-05-07T03:09:07Z

Changes:

Tablet view for Dtrader, Reports and TradersHub

DTrader and Reports breakpoints:
remove blocking message about adjusting size;
if width <600 - responsive;
width between 600 - 1279 - tablet + web-version + lock users for landscape mode
if width > 1280 desktop
Footer + Header - responsive;

Users will open Dtrader from Trader's Hub - we will not show them landscape blocker

* feat: tablet view * revert: trade params test cases * chore: remove unused imports * chore: added test case for usedevice * fix: height * fix: accumulators stats * fix: layout * fix: test * refactor: update test * refactor: change mixins names * fix: platform switcher * refactor: remove shared isnewmobile and fix styles in contract page * fix: blocker showing in different page besides dtrader, comments * fix: comments * revert: unneded changes * fix: test failed * fix: breaking designs because of rtl * feat: empty * fix: account switcher * fix: account switcher and add blocker on portrait * chore: update test case * refactor: replace with hook from deriv-com/ui * fix: failing test cases * chore: update deriv-com/ui and remove redundant hook * fix: useonclickoutside

* feat: update to deriv-com/ui * feat: delete landscape blocker * feat: add some mixins * feat: complete with mixins * feat: modify traders hub main page * feat: modify main title * feat: modify asset-summary * feat: modify asset-summary styles * feat: modify listing-container and currency-switcher styles * feat: modify header * feat: get back package-lock.json * fix: add some our library to ignore patterns for jest * chore: empty commit * feat: get back landscape_blocker * feat: better to update it in base.config intead of writing it in both files * feat: update package.json * feat: create hook to hide landscape_blocker * feat: move landscape blocker to the react compnent * feat: add routes to LandscapeBlocker * feat: add mock for deriv-com/ui in globals.js * fix: fix one test * feat: remove jest deriv-com/ui from globals * fix: trying to fix tests again * fix: fix again and again * fix: fix test case again * feat: add isDesktop check for cfds-listing * feat: override some styles * feat: change breakpoints for footer * fix: change package version * feat: update mixins based on Farhan PR * fix: fix lint issue * feat: delete useEffect in App of trader package and style for landscape blocker * feat: modify footer * chore: made decision to delete unreachable code * feat: get changes back for app component in trader package * feat: remove routes.root from disable blocker array * feat: change condition to else * feat: implement review suggestions and fix mixin * feat: rename sccs file * feat: get changes back for trading.scss * feat: implemet review suggestions

…odal and Compare CFDs Accounts modal (#14799) * feat: modify regulators compare modal component * feat: add correct mixins for cfd-compare-accounts modal * fix: add resolver for react/jsx-runtime * fix: mock deriv-com/ui useDevice hook * feat: implement review suggestions

vercel · 2024-05-07T03:09:13Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	Jun 26, 2024 7:40am

* chore: reports pages tablet view * style: update width as per figma design * refactor: landscape cloker component * fix: comments * chore: use bitwise to avoid nan value * fix: comments * fix: import * chore: update function

github-actions · 2024-05-07T05:14:47Z

A production App ID was automatically generated for this PR. (log)

PR: [FEQ-2166]/Tablet view - Reports, Dtrader, Tradershub #15011
URLs:
- w/ App ID + Server: https://deriv-app-git-tabletview.binary.sx?qa_server=red.derivws.com&app_id=24072
- Original: https://deriv-app-git-tabletview.binary.sx
App ID: 24072

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/15011](https://github.com/binary-com/deriv-app/pull/15011)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-tabletview.binary.sx?qa_server=red.derivws.com&app_id=24072
    - **Original**: https://deriv-app-git-tabletview.binary.sx
- **App ID**: `24072`

github-actions · 2024-05-07T05:16:22Z

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	31
🟧 Accessibility	70
🟧 Best practices	83
🟧 SEO	77
🟧 PWA	78

Lighthouse ran with https://deriv-app-git-tabletview.binary.sx/

* chore: lock landscape mode on tablet view * chore: only show tablet view on real tablet * fix: notification * chore: change implementation * fix: change root * refactor: comments * fix: comments * fix: height * fix: rtl language * refactor: remove extra property * fix: positions modal height based on figma * chore: add loader before rotating the screen * fix: failing test * chore: add timeout before hiding loader * style: move styles * chore: another ref for loader timeout cleanup * fix: hide footer for dtrader

…view

This reverts commit ef2dddb.

) * fix: creation banner and adding mt5 account * feat: add deriv-com/ui to account package json * fix: add react/jsx-runtime to webpack resolvers because i have added deriv-com/ui to package json

* feat: tablet view suggestion * feat: implement new design for tablet

…view

github-actions · 2024-06-25T06:36:28Z

package	old	new	diff	pct change
account	231 KB	231 KB	+486 B	+0.2% 🟢
appstore	771 KB	775 KB	+4 KB	+0.6% 🟡
bot-web-ui	839 KB	839 KB	+9 B	+0.0% 🟢
cashier	682 KB	682 KB	0 B	0% 🟢
cashier-v2	3.0 MB	3.0 MB	+3 KB	+0.1% 🟢
cfd	494 KB	496 KB	+2 KB	+0.4% 🟢
core	6.6 MB	6.6 MB	+2 KB	+0.0% 🟢
p2p	985 KB	990 KB	+5 KB	+0.5% 🟡
p2p-v2	3.4 MB	3.4 MB	+4 KB	+0.1% 🟢
reports	94 KB	95 KB	+394 B	+0.4% 🟢
trader	318 KB	320 KB	+2 KB	+0.5% 🟡
wallets	3.7 MB	3.7 MB	+3 KB	+0.1% 🟢

github-actions · 2024-06-25T08:27:12Z

package	old	new	diff	pct change
account	231 KB	231 KB	+486 B	+0.2% 🟢
appstore	771 KB	775 KB	+4 KB	+0.6% 🟡
bot-web-ui	839 KB	839 KB	+9 B	+0.0% 🟢
cashier	682 KB	682 KB	0 B	0% 🟢
cashier-v2	3.0 MB	3.0 MB	+3 KB	+0.1% 🟢
cfd	494 KB	496 KB	+2 KB	+0.4% 🟢
core	6.6 MB	6.6 MB	+2 KB	+0.0% 🟢
p2p	985 KB	990 KB	+5 KB	+0.5% 🟡
p2p-v2	3.4 MB	3.4 MB	+4 KB	+0.1% 🟢
reports	94 KB	95 KB	+394 B	+0.4% 🟢
trader	318 KB	320 KB	+2 KB	+0.5% 🟡
wallets	3.7 MB	3.7 MB	+3 KB	+0.1% 🟢

coveralls · 2024-06-25T09:15:16Z

coverage: 45.545% (-0.006%) from 45.551%
when pulling a0f0229 on tablet_view
into 23354ea on master.

…view

sonarcloud · 2024-06-26T07:13:58Z

Quality Gate passed

Issues
13 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.8% Duplication on New Code

See analysis details on SonarCloud

github-actions · 2024-06-26T07:29:29Z

package	old	new	diff	pct change
account	231 KB	231 KB	+486 B	+0.2% 🟢
appstore	775 KB	779 KB	+4 KB	+0.6% 🟡
bot-web-ui	839 KB	839 KB	+9 B	+0.0% 🟢
cashier	684 KB	684 KB	0 B	0% 🟢
cashier-v2	3.0 MB	3.0 MB	+3 KB	+0.1% 🟢
cfd	498 KB	500 KB	+2 KB	+0.4% 🟢
core	6.6 MB	6.6 MB	+2 KB	+0.0% 🟢
p2p	986 KB	996 KB	+9 KB	+1.0% 🟡
p2p-v2	3.4 MB	3.4 MB	+4 KB	+0.1% 🟢
reports	94 KB	95 KB	+394 B	+0.4% 🟢
trader	318 KB	320 KB	+2 KB	+0.5% 🟡
wallets	3.7 MB	3.7 MB	+3 KB	+0.1% 🟢

coveralls · 2024-06-26T08:54:53Z

coverage: 45.522% (-0.004%) from 45.526%
when pulling e540069 on tablet_view
into 249894c on master.

farhan-nurzi-deriv and others added 3 commits April 23, 2024 16:16

habib-deriv requested review from matin-deriv, thisyahlen-deriv, maryia-deriv, farrah-deriv, nijil-deriv, ali-hosseini-deriv, hirad-deriv, wojciech-deriv, sandeep-deriv, vinu-deriv, amina-deriv, balakrishna-deriv, yashim-deriv and markw-deriv as code owners May 7, 2024 03:09

boring-cyborg bot added Account AppStore Bot labels May 7, 2024

Farhan/DTRA-1195/Reports's tablet view (#14772)

4359cab

* chore: reports pages tablet view * style: update width as per figma design * refactor: landscape cloker component * fix: comments * chore: use bitwise to avoid nan value * fix: comments * fix: import * chore: update function

vercel bot temporarily deployed to Preview May 7, 2024 05:40 Inactive

vercel bot temporarily deployed to Preview May 9, 2024 07:53 Inactive

Merge branch 'master' of github.com:binary-com/deriv-app into tablet_…

5aaa26c

…view

balakrishna-deriv temporarily deployed to Preview May 9, 2024 08:20 — with GitHub Actions Inactive

fix: creation banner and adding mt5 account (#15659)

ef2dddb

vercel bot had a problem deploying to Preview June 14, 2024 03:01 Failure

Revert "fix: creation banner and adding mt5 account (#15659)" (#15661)

445f55c

This reverts commit ef2dddb.

vercel bot temporarily deployed to Preview June 14, 2024 03:26 Inactive

[FEQ] Sergei / FEQ - 2374, 2375, 2376 / Tablet view issues 4 (2) (#15666

aa6fd7b

) * fix: creation banner and adding mt5 account * feat: add deriv-com/ui to account package json * fix: add react/jsx-runtime to webpack resolvers because i have added deriv-com/ui to package json

vercel bot temporarily deployed to Preview June 14, 2024 09:36 Inactive

[FEQ] Sergei / FEQ - 2376 / "Get real account" button for DIEL (#15690)

a09d8b7

* feat: tablet view suggestion * feat: implement new design for tablet

vercel bot temporarily deployed to Preview June 20, 2024 06:18 Inactive

Merge branch 'master' of github.com:binary-com/deriv-app into tablet_…

218628f

…view

balakrishna-deriv temporarily deployed to Preview June 25, 2024 06:17 — with GitHub Actions Inactive

chore: fix test cases

a0f0229

balakrishna-deriv temporarily deployed to Preview June 25, 2024 08:08 — with GitHub Actions Inactive

balakrishna-deriv added 2 commits June 26, 2024 14:43

chore: add observer

4481f6c

Merge branch 'master' of github.com:binary-com/deriv-app into tablet_…

e540069

…view

balakrishna-deriv temporarily deployed to Preview June 26, 2024 07:10 — with GitHub Actions Inactive

balakrishna-deriv merged commit 9765c27 into master Jun 26, 2024
9 checks passed

maryia-deriv mentioned this pull request Jun 27, 2024

[DTRA] Maryia/WEBREL-2873/fix: spacing issue between filters and table in Reports #15824

Merged

ali-hosseini-deriv deleted the tablet_view branch August 16, 2024 11:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FEQ-2166]/Tablet view - Reports, Dtrader, Tradershub #15011

[FEQ-2166]/Tablet view - Reports, Dtrader, Tradershub #15011

habib-deriv commented May 7, 2024 •

edited

Loading

vercel bot commented May 7, 2024 •

edited

Loading

github-actions bot commented May 7, 2024 •

edited

Loading

github-actions bot commented May 7, 2024 •

edited

Loading

github-actions bot commented Jun 25, 2024

github-actions bot commented Jun 25, 2024

coveralls commented Jun 25, 2024

sonarcloud bot commented Jun 26, 2024

github-actions bot commented Jun 26, 2024

coveralls commented Jun 26, 2024

[FEQ-2166]/Tablet view - Reports, Dtrader, Tradershub #15011

[FEQ-2166]/Tablet view - Reports, Dtrader, Tradershub #15011

Conversation

habib-deriv commented May 7, 2024 • edited Loading

Changes:

vercel bot commented May 7, 2024 • edited Loading

github-actions bot commented May 7, 2024 • edited Loading

github-actions bot commented May 7, 2024 • edited Loading

github-actions bot commented Jun 25, 2024

github-actions bot commented Jun 25, 2024

coveralls commented Jun 25, 2024

sonarcloud bot commented Jun 26, 2024

Quality Gate passed

github-actions bot commented Jun 26, 2024

coveralls commented Jun 26, 2024

habib-deriv commented May 7, 2024 •

edited

Loading

vercel bot commented May 7, 2024 •

edited

Loading

github-actions bot commented May 7, 2024 •

edited

Loading

github-actions bot commented May 7, 2024 •

edited

Loading