[FEQ] Sergei / FEQ - 2374, 2375, 2376 / Tablet view issues 4 (2) #15666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergei-deriv
requested review from
matin-deriv,
nijil-deriv,
amina-deriv and
maryia-deriv
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-sergei-deriv-sergei-feq-2374-2tablet-a2a41b.binary.sx/ |
…deriv-com/ui to package json
|
habib-deriv
approved these changes
Jun 14, 2024
balakrishna-deriv
added a commit
that referenced
this pull request
Jun 26, 2024
* [DTRA] Farhan/DTRA-945/Dtrader's Tablet View (#14346) * feat: tablet view * revert: trade params test cases * chore: remove unused imports * chore: added test case for usedevice * fix: height * fix: accumulators stats * fix: layout * fix: test * refactor: update test * refactor: change mixins names * fix: platform switcher * refactor: remove shared isnewmobile and fix styles in contract page * fix: blocker showing in different page besides dtrader, comments * fix: comments * revert: unneded changes * fix: test failed * fix: breaking designs because of rtl * feat: empty * fix: account switcher * fix: account switcher and add blocker on portrait * chore: update test case * refactor: replace with hook from deriv-com/ui * fix: failing test cases * chore: update deriv-com/ui and remove redundant hook * fix: useonclickoutside * [TRAH] Sergei / TRAH - 2761 / Trader's hub tablet view (#13396) * feat: update to deriv-com/ui * feat: delete landscape blocker * feat: add some mixins * feat: complete with mixins * feat: modify traders hub main page * feat: modify main title * feat: modify asset-summary * feat: modify asset-summary styles * feat: modify listing-container and currency-switcher styles * feat: modify header * feat: get back package-lock.json * fix: add some our library to ignore patterns for jest * chore: empty commit * feat: get back landscape_blocker * feat: better to update it in base.config intead of writing it in both files * feat: update package.json * feat: create hook to hide landscape_blocker * feat: move landscape blocker to the react compnent * feat: add routes to LandscapeBlocker * feat: add mock for deriv-com/ui in globals.js * fix: fix one test * feat: remove jest deriv-com/ui from globals * fix: trying to fix tests again * fix: fix again and again * fix: fix test case again * feat: add isDesktop check for cfds-listing * feat: override some styles * feat: change breakpoints for footer * fix: change package version * feat: update mixins based on Farhan PR * fix: fix lint issue * feat: delete useEffect in App of trader package and style for landscape blocker * feat: modify footer * chore: made decision to delete unreachable code * feat: get changes back for app component in trader package * feat: remove routes.root from disable blocker array * feat: change condition to else * feat: implement review suggestions and fix mixin * feat: rename sccs file * feat: get changes back for trading.scss * feat: implemet review suggestions * [TRAH] Sergei / TRAH-2762, TRAH-2763 / Tablet view for Jurisdiction Modal and Compare CFDs Accounts modal (#14799) * feat: modify regulators compare modal component * feat: add correct mixins for cfd-compare-accounts modal * fix: add resolver for react/jsx-runtime * fix: mock deriv-com/ui useDevice hook * feat: implement review suggestions * Farhan/DTRA-1195/Reports's tablet view (#14772) * chore: reports pages tablet view * style: update width as per figma design * refactor: landscape cloker component * fix: comments * chore: use bitwise to avoid nan value * fix: comments * fix: import * chore: update function * Farhan/Lock Dtrader Tablet View on Landscape Mode (#14781) * chore: lock landscape mode on tablet view * chore: only show tablet view on real tablet * fix: notification * chore: change implementation * fix: change root * refactor: comments * fix: comments * fix: height * fix: rtl language * refactor: remove extra property * fix: positions modal height based on figma * chore: add loader before rotating the screen * fix: failing test * chore: add timeout before hiding loader * style: move styles * chore: another ref for loader timeout cleanup * fix: hide footer for dtrader * DTRA / Kate / FEQ-2212 / Hide footer navigation links popovers (#15176) * fix: add check for desktop * refactor: add custom check for tablet os * refactor: revert changes from endpoint note and server time * refactor: device detection * fix: style and update function for detection tablet os * chore: remove empty space * chore: remove used type * DTRA / Kate / FEQ-2213 + FEQ-2205 / Made popover optional (#15197) * fix: add check for purchase button popover for tablet * fix: make popover optional for header * refactor: add condition for wallets header * [DTRA] Farhan/Dtrader Tablet Subtasks (#15123) * chore: lock landscape mode on tablet view * chore: only show tablet view on real tablet * fix: notification * chore: change implementation * fix: change root * refactor: comments * fix: comments * fix: height * fix: rtl language * refactor: remove extra property * fix: positions modal height based on figma * chore: add loader before rotating the screen * fix: failing test * chore: add timeout before hiding loader * style: move styles * chore: another ref for loader timeout cleanup * fix: hide footer for dtrader * chore: update os detect * fix: failing tests * fix: height issue * fix: android device issue and toolbar widgets * fix: reports height * fix: test failing * fix: position drawer on ios * refactor: remove unused prop * fix: route for contract --------- Co-authored-by: balakrishna-deriv <56330681+balakrishna-deriv@users.noreply.github.com> * chore: update @deriv/deriv-charts to 2.1.16 (#15212) Co-authored-by: balakrishna-deriv <balakrishna-deriv@users.noreply.github.com> * [DTRA] Farhan/Fix test failing (#15216) * chore: lock landscape mode on tablet view * chore: only show tablet view on real tablet * fix: notification * chore: change implementation * fix: change root * refactor: comments * fix: comments * fix: height * fix: rtl language * refactor: remove extra property * fix: positions modal height based on figma * chore: add loader before rotating the screen * fix: failing test * chore: add timeout before hiding loader * style: move styles * chore: another ref for loader timeout cleanup * fix: hide footer for dtrader * chore: update os detect * fix: failing tests * fix: height issue * fix: android device issue and toolbar widgets * fix: reports height * fix: test failing * fix: position drawer on ios * refactor: remove unused prop * fix: route for contract * fix: failing test and ts * fix: miseed ts errors --------- Co-authored-by: balakrishna-deriv <56330681+balakrishna-deriv@users.noreply.github.com> * feat: get changes back and just delete mixin for tablet (#15182) * [FEQ] Sergei / FEQ-2200, FEQ-2201 / Add a real MT5 account, Identity verification, Choose a jurisdiction popup for tablet (#15205) * feat: change styles for mt5 jurisdiction modal * feat: change styles for adding a real mt5 account modal * feat: change more styles * fix: add mock for useDevice hook from deriv-com/ui * [DTRA] Farhan/FEQ-2208/Hide indicators and drawing tools toolbar widgets on tablet (#15224) * chore: lock landscape mode on tablet view * chore: only show tablet view on real tablet * fix: notification * chore: change implementation * fix: change root * refactor: comments * fix: comments * fix: height * fix: rtl language * refactor: remove extra property * fix: positions modal height based on figma * chore: add loader before rotating the screen * fix: failing test * chore: add timeout before hiding loader * style: move styles * chore: another ref for loader timeout cleanup * fix: hide footer for dtrader * chore: update os detect * fix: failing tests * fix: height issue * fix: android device issue and toolbar widgets * fix: reports height * fix: test failing * fix: position drawer on ios * refactor: remove unused prop * fix: route for contract * fix: failing test and ts * fix: miseed ts errors * fix: hide indicators and drawing tools for tablet view * fix: test case * fix: height reports --------- Co-authored-by: balakrishna-deriv <56330681+balakrishna-deriv@users.noreply.github.com> * [DTRA] Farhan/FEQ-2205/Header notification icon and account settings links are not working as expected (#15275) * fix: hide popover on traders hub header * fix: account switcher width * fix: comments * feat: change mixins and add isTablet for datepicker (#15349) * feat: change 2 desktop mixins (#15362) * [DTRA] Farhan/Tablet view subtasks (#15376) * fix: subtasks 2 * fix: failing tests * [DTRA] Farhan/FEQ-2280/tablet subtasks (#15404) * fix: subtasks 2 * fix: failing tests * fix: positions toggle icon * refactor: digit breakpoint * fix: drawer moving when coming back from reports * fix: tablet tooltip * fix: hide download widget for tablet * fix: report open position footer * fix: double sell button * fix: digit container * fix: failing tests * fix: tests --------- Co-authored-by: Farhan Ahmad Nurzi <farhan.nurzi@regentmarkets.com> * FEQ-2313 / Kate / Android tablet- Long code message content is showing in smaller size (#15474) * fix: css for link * fix: css * chore: get back line height * refactor: add tablet os check and revert style changes * Fix tablet view issues (#15469) * fix: jest test trader * fix: alignment issues * fix: test cases * fix: contract type dialog height (#15476) * Ahmad/Fix Strike Icon color on firefox (#15481) * chore: strike icon * fix: revert all * fix: tablet issues (#15497) * chore: remove unused hook * [FEX] Sergei / FEQ - 2310, 2311, 2319, 2320, 2344 / Tablet view issues #3 (#15522) * fix: change isDisabledLandscapeBlockerRoute because traders hub route now is the root route * feat: make logged out version of TH accesable for tablet view * feat: add styles for mt5 password modal * feat: fix notifications styles * Ahmad/Strike Icon Svg fix on Firefox (#15578) * chore: strike icon * fix: revert all * chore: add important * Ahmad/ Fiix Strike Icon in firefox and update Deriv UI Package (#15609) * chore: strike icon * fix: revert all * chore: add important * fix: update packages and remove temp fix * fix: creation banner and adding mt5 account (#15659) * Revert "fix: creation banner and adding mt5 account (#15659)" (#15661) This reverts commit ef2dddb. * [FEQ] Sergei / FEQ - 2374, 2375, 2376 / Tablet view issues 4 (2) (#15666) * fix: creation banner and adding mt5 account * feat: add deriv-com/ui to account package json * fix: add react/jsx-runtime to webpack resolvers because i have added deriv-com/ui to package json * [FEQ] Sergei / FEQ - 2376 / "Get real account" button for DIEL (#15690) * feat: tablet view suggestion * feat: implement new design for tablet * chore: fix test cases * chore: add observer --------- Co-authored-by: Farhan Ahmad Nurzi <125247833+farhan-nurzi-deriv@users.noreply.github.com> Co-authored-by: Sergei Baranovski <120570511+sergei-deriv@users.noreply.github.com> Co-authored-by: balakrishna-binary <bala.krishna@regentmarkets.com> Co-authored-by: kate-deriv <121025168+kate-deriv@users.noreply.github.com> Co-authored-by: balakrishna-deriv <56330681+balakrishna-deriv@users.noreply.github.com> Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> Co-authored-by: balakrishna-deriv <balakrishna-deriv@users.noreply.github.com> Co-authored-by: Farhan Ahmad Nurzi <farhan.nurzi@regentmarkets.com> Co-authored-by: Akmal Djumakhodjaev <akmal@binary.com> Co-authored-by: ahmadtaimoor-deriv <129935294+ahmadtaimoor-deriv@users.noreply.github.com>
amina-deriv
added a commit
that referenced
this pull request
Jul 1, 2024
* Farhan/Lock Dtrader Tablet View on Landscape Mode (#14781) * chore: lock landscape mode on tablet view * chore: only show tablet view on real tablet * fix: notification * chore: change implementation * fix: change root * refactor: comments * fix: comments * fix: height * fix: rtl language * refactor: remove extra property * fix: positions modal height based on figma * chore: add loader before rotating the screen * fix: failing test * chore: add timeout before hiding loader * style: move styles * chore: another ref for loader timeout cleanup * fix: hide footer for dtrader * feat: added teamp breakpoints * feat: enable tablet view on accounts * feat: enabled table view for financial assessment * feat: tablet design for personal details * chore: update css files * feat: enable table view for financial assesment * feat: enabled tablet view * feat: removed unwanted code * feat: updated with logical property * feat: removd ui store and added devices * feat: updated nav condition * fix: removed usage of is_mobile, changed mixin name with latest, footer * fix: padding of content and footer btn * DTRA / Kate / FEQ-2212 / Hide footer navigation links popovers (#15176) * fix: add check for desktop * refactor: add custom check for tablet os * refactor: revert changes from endpoint note and server time * refactor: device detection * fix: style and update function for detection tablet os * chore: remove empty space * chore: remove used type * DTRA / Kate / FEQ-2213 + FEQ-2205 / Made popover optional (#15197) * fix: add check for purchase button popover for tablet * fix: make popover optional for header * refactor: add condition for wallets header * [DTRA] Farhan/Dtrader Tablet Subtasks (#15123) * chore: lock landscape mode on tablet view * chore: only show tablet view on real tablet * fix: notification * chore: change implementation * fix: change root * refactor: comments * fix: comments * fix: height * fix: rtl language * refactor: remove extra property * fix: positions modal height based on figma * chore: add loader before rotating the screen * fix: failing test * chore: add timeout before hiding loader * style: move styles * chore: another ref for loader timeout cleanup * fix: hide footer for dtrader * chore: update os detect * fix: failing tests * fix: height issue * fix: android device issue and toolbar widgets * fix: reports height * fix: test failing * fix: position drawer on ios * refactor: remove unused prop * fix: route for contract --------- Co-authored-by: balakrishna-deriv <56330681+balakrishna-deriv@users.noreply.github.com> * chore: update @deriv/deriv-charts to 2.1.16 (#15212) Co-authored-by: balakrishna-deriv <balakrishna-deriv@users.noreply.github.com> * style: initial style changes * feat: tablet view changes for languages * feat: removed unwanted new line * [DTRA] Farhan/Fix test failing (#15216) * chore: lock landscape mode on tablet view * chore: only show tablet view on real tablet * fix: notification * chore: change implementation * fix: change root * refactor: comments * fix: comments * fix: height * fix: rtl language * refactor: remove extra property * fix: positions modal height based on figma * chore: add loader before rotating the screen * fix: failing test * chore: add timeout before hiding loader * style: move styles * chore: another ref for loader timeout cleanup * fix: hide footer for dtrader * chore: update os detect * fix: failing tests * fix: height issue * fix: android device issue and toolbar widgets * fix: reports height * fix: test failing * fix: position drawer on ios * refactor: remove unused prop * fix: route for contract * fix: failing test and ts * fix: miseed ts errors --------- Co-authored-by: balakrishna-deriv <56330681+balakrishna-deriv@users.noreply.github.com> * feat: get changes back and just delete mixin for tablet (#15182) * [FEQ] Sergei / FEQ-2200, FEQ-2201 / Add a real MT5 account, Identity verification, Choose a jurisdiction popup for tablet (#15205) * feat: change styles for mt5 jurisdiction modal * feat: change styles for adding a real mt5 account modal * feat: change more styles * fix: add mock for useDevice hook from deriv-com/ui * style: update self-exclusion deign tablet * chore: update mixin names * feat: enabled tablet view for trading assessment * style: tablet design api token * [DTRA] Farhan/FEQ-2208/Hide indicators and drawing tools toolbar widgets on tablet (#15224) * chore: lock landscape mode on tablet view * chore: only show tablet view on real tablet * fix: notification * chore: change implementation * fix: change root * refactor: comments * fix: comments * fix: height * fix: rtl language * refactor: remove extra property * fix: positions modal height based on figma * chore: add loader before rotating the screen * fix: failing test * chore: add timeout before hiding loader * style: move styles * chore: another ref for loader timeout cleanup * fix: hide footer for dtrader * chore: update os detect * fix: failing tests * fix: height issue * fix: android device issue and toolbar widgets * fix: reports height * fix: test failing * fix: position drawer on ios * refactor: remove unused prop * fix: route for contract * fix: failing test and ts * fix: miseed ts errors * fix: hide indicators and drawing tools for tablet view * fix: test case * fix: height reports --------- Co-authored-by: balakrishna-deriv <56330681+balakrishna-deriv@users.noreply.github.com> * style: tablet design acnt limits * feat: enabled poa for tablet view * feat: removed unused code * feat: used not desktop breakpoint * fix: lof=gical property for css * fix: css * feat: updated device hook * style: tablet view, modal fix * style: tablet view changes for various POO status components, common-css * [DTRA] Farhan/FEQ-2205/Header notification icon and account settings links are not working as expected (#15275) * fix: hide popover on traders hub header * fix: account switcher width * fix: comments * feat: enabled tablet view for proof of income section * style: tablet view for 2FA * fix: build_issue * chore: email-pswd-section * feat: change mixins and add isTablet for datepicker (#15349) * feat: change 2 desktop mixins (#15362) * fix: new button fixes * fix: fixed containers * fix: fixed comments1 * fix: fixed bug in desktop view * fix: fixed comments 2 * fix: fixed comments 5 * fix: fixed comments 6 * fix: fixed padding and changed px to rem * fix: removed lines * fix: fixed code * feat: added missing code which already merged * chore: clean code * fix: remove unused css * fix: personal details section * [DTRA] Farhan/Tablet view subtasks (#15376) * fix: subtasks 2 * fix: failing tests * fix: fixed scrolling issue for tablet and mobile * chore: remove old is mobile and is desktop and added new * fix: removed unwanted code * fix: fixed footer width * test: fix testcases for useDevice hook * test: update api-token testcase * test: update api-token testcase * fix: fixed width and scroll issue * test: update api-token testcase * chore: added new break points and removed old * fix: update testcases * fix: close-acnt modal * fix: address comments * fix: address comments * [DTRA] Farhan/FEQ-2280/tablet subtasks (#15404) * fix: subtasks 2 * fix: failing tests * fix: positions toggle icon * refactor: digit breakpoint * fix: drawer moving when coming back from reports * fix: tablet tooltip * fix: hide download widget for tablet * fix: report open position footer * fix: double sell button * fix: digit container * fix: failing tests * fix: tests --------- Co-authored-by: Farhan Ahmad Nurzi <farhan.nurzi@regentmarkets.com> * chore: removed drag drop for tablet view * fix: use new breakpoints r passkeys components * fix: POI test cases * fix: POI test cases2 * fix: POI test cases3 * fix: clean up and test cases in POI * fix: POI clean up * fix: style for tradingassessment * fix: cleanup 3 * fix: style for tradingassessment * fix: removed height * fix: removed typoerror * fix: removed code2 * chore: remove desktop/mobile wrappers * chore: remove desktop/mobile wrappers * fix: rtl changes * style: update closing acnt * chore: update prop name * chore: update prop name * style: close account margin * fix: added missing code * fix: added missing code2 * chore: resovled conflicts * fix: replaced Desktop() with useDevice hook * fix: replaced Desktop() with useDevice hook2 * fix: replaced Desktop() with useDevice hook3 * fix: replaced Desktop() with useDevice hook4 * fix: replaced Desktop() with useDevice hook5 * fix: replaced Desktop() with useDevice hook5 * style: empty commit to resolve conflicts * FEQ-2313 / Kate / Android tablet- Long code message content is showing in smaller size (#15474) * fix: css for link * fix: css * chore: get back line height * refactor: add tablet os check and revert style changes * Fix tablet view issues (#15469) * fix: jest test trader * fix: alignment issues * fix: test cases * fix: contract type dialog height (#15476) * fix: added isDesktop to missing places2 * chore: fixed modal height issue and semicolon issue * chore: removed extra semicolon * fix: added isDesktop to missing places3 * fix: personal details error * fix: added isDesktop to missing places4 * Ahmad/Fix Strike Icon color on firefox (#15481) * chore: strike icon * fix: revert all * fix: tablet issues (#15497) * fix: padding top for sections * chore: fixed semocolon and scrollbar issue * fix: fieldset max width * fix: close acnt btn alignment * fix: fixed scroll and padding in POI * fix: close acnt btn alignment * fix: px to rem fix * fix: testcases * chore: remove unused hook * chore: updated with parent branch and resolved conflicts * Revert "Fasih/ Updated with parent branch and resolved conflicts" * fix: poi scroll screen issue * [FEX] Sergei / FEQ - 2310, 2311, 2319, 2320, 2344 / Tablet view issues #3 (#15522) * fix: change isDisabledLandscapeBlockerRoute because traders hub route now is the root route * feat: make logged out version of TH accesable for tablet view * feat: add styles for mt5 password modal * feat: fix notifications styles * fix: fixed build issue * fix: added test cases for passkeys * Ahmad/Strike Icon Svg fix on Firefox (#15578) * chore: strike icon * fix: revert all * chore: add important * fix: poi fixes1 * fix: fixed testcases * fix: fixed testcases2 * fix: poi fixes2 * Ahmad/ Fiix Strike Icon in firefox and update Deriv UI Package (#15609) * chore: strike icon * fix: revert all * chore: add important * fix: update packages and remove temp fix * fix: address comments * fix: selfexclusion testcase * fix: trading-assessment-user-observer-remove * fix: api and connected apps * fix: css fixes * fix: icon1 * chore: resolved comments and added fragment * fix: self exclusion and css * fix: endpoint page * fix: creation banner and adding mt5 account (#15659) * Revert "fix: creation banner and adding mt5 account (#15659)" (#15661) This reverts commit ef2dddb. * fix: api token layout * [FEQ] Sergei / FEQ - 2374, 2375, 2376 / Tablet view issues 4 (2) (#15666) * fix: creation banner and adding mt5 account * feat: add deriv-com/ui to account package json * fix: add react/jsx-runtime to webpack resolvers because i have added deriv-com/ui to package json * chore: fixed width of tray on mobile * chore: addressed comments * chore: removed duplicated import * fix: border radius api card * fix: btn aligmnent desktop * fix: pull invalid date fix * chore: back btn margin fix * [FEQ] Sergei / FEQ - 2376 / "Get real account" button for DIEL (#15690) * feat: tablet view suggestion * feat: implement new design for tablet * fix: fix passkeys and coverall issue * fix: build fail * fix: build fail * fix: fix import --------- Co-authored-by: Farhan Ahmad Nurzi <125247833+farhan-nurzi-deriv@users.noreply.github.com> Co-authored-by: balakrishna-binary <bala.krishna@regentmarkets.com> Co-authored-by: Muhammad Fasih Ali Naqvi <muhammadfasih@Muhammad-Fasihs-Mac-X7KDC4NKQ0-Standard.local> Co-authored-by: utkarsha-deriv <utkarsha@regentmarkets.com> Co-authored-by: kate-deriv <121025168+kate-deriv@users.noreply.github.com> Co-authored-by: balakrishna-deriv <56330681+balakrishna-deriv@users.noreply.github.com> Co-authored-by: utkarsha-deriv <125863995+utkarsha-deriv@users.noreply.github.com> Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> Co-authored-by: balakrishna-deriv <balakrishna-deriv@users.noreply.github.com> Co-authored-by: Sergei Baranovski <120570511+sergei-deriv@users.noreply.github.com> Co-authored-by: fasihali-deriv <121229483+fasihali-deriv@users.noreply.github.com> Co-authored-by: Dhruv Neb <dhruv@regentmarkets.com> Co-authored-by: Farhan Ahmad Nurzi <farhan.nurzi@regentmarkets.com> Co-authored-by: Muhammad Fasih Ali Naqvi <muhammadfasih@Muhammad-Fasihs-Mac-X7KDC4NKQ0-Standard-No-NextDNS.local> Co-authored-by: Akmal Djumakhodjaev <akmal@binary.com> Co-authored-by: ahmadtaimoor-deriv <129935294+ahmadtaimoor-deriv@users.noreply.github.com> Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> Co-authored-by: Habib Deriv <88178645+habib-deriv@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Change mobile mixins for mobile-or-tablet mixins, and change js breakpoints for tablet view